Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unblock Datagen 1.3 by releasing Elsa or reverting to an older version of Elsa #3831

Closed
sffc opened this issue Aug 10, 2023 · 3 comments
Closed

Comments

@sffc
Copy link
Member

sffc commented Aug 10, 2023

Datagen depends on a git hash of Elsa because the test test_fallback_options uses an unreleased API. We have a few choices:

  1. Release Elsa and update ICU4X's Cargo.toml to remove the git hash
  2. Change ICU4X to not use the new Elsa APIs (use a RwLock<HashMap> instead)
    • Pro: No external dependency
    • Con: Less pretty code
  3. Depend on the git hash in dev-dependencies only
    • Pro: Unblocks the release with no code changes
    • Con: Multiple versions of Elsa in tree

@Manishearth @robertbastian

@sffc sffc added the discuss Discuss at a future ICU4X-SC meeting label Aug 10, 2023
@sffc sffc added this to the 1.3 Blocking ⟨P1⟩ milestone Aug 10, 2023
@Manishearth
Copy link
Member

Manishearth commented Aug 10, 2023

I'm planning on releasing a non breaking release, I just have a backlog of things to do on elsa. I thought I already communicated this; I was just busy that week. I can do this now and ignore the backlog.

@Manishearth
Copy link
Member

Manishearth commented Aug 10, 2023

newly added APIs are unsound

No, it's existing APIs, but it changes the model of the type and raises questions of how to best support other APIs, including the one we're using (though the one we're using can be made to work regardless, it's just potentially more work)

Oh if we're using into_tuple_vec that's fine

@Manishearth
Copy link
Member

Elsa 1.9.0 published

@sffc sffc removed the discuss Discuss at a future ICU4X-SC meeting label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants