Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a wider range of RHEL clones #16

Open
wiene opened this issue Oct 31, 2021 · 2 comments
Open

Add support for a wider range of RHEL clones #16

wiene opened this issue Oct 31, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@wiene
Copy link
Member

wiene commented Oct 31, 2021

Given the developments in the CentOS Project we should support a wider range of RHEL clones.

@wiene wiene added the enhancement New feature or request label Oct 31, 2021
@wiene
Copy link
Member Author

wiene commented Oct 31, 2021

@olifre proposed to use $facts['os']['family'] == 'RedHat' rather than $facts['os']['name'] == 'CentOS' in the manifest/params.pp code.

A potential loophole is that Fedora hosts would probably also belong to the RedHat family and the code will not work on ancient Fedora Linux 7 and Fedora Linux 8 (according to this page, they were released before the publication of Python 3). But probably this is rather a theoretical than a practical problem.

Apart from this, the proposed solution is definitely nicer than maintaining a list of RHEL clone names.

@olifre what do you think?

@olifre
Copy link
Member

olifre commented Oct 31, 2021

Fedora hosts would probably also belong to the RedHat family

That does indeed seem to be true:
https://github.com/puppetlabs/facter/blob/dfbfd3b88ea433b4ace69e0cd192226ff9f1dfeb/acceptance/lib/facter/acceptance/base_fact_utils.rb#L297-L301

But probably this is rather a theoretical than a practical problem.

I agree, effectively, this means we are not supporting ancient Fedora releases ;-).

Given the currently known rebuilds (AlmaLinux, Rocky Linux) and also other related RedHat family distros (Oracle Linux, Amazon Linux, Scientific Linux) and the rate at which these change, going for the RedHat family seems to be the only maintainable option. We could (later on) add the list of tested distributions to our metadata.json and add unit tests to communicate more clearly which distros we have tested things on.

Further down the road, we may want to migrate to the hiera-based approach which modules like puppet-systemd are using to provide OS-specific defaults (this also allows to get rid of params.pp altogether and use a yaml-based syntax instead).

@wiene what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants