Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] The logo of streaming services cannot be hidden #133

Closed
1 task done
JoeyNoProVN opened this issue Dec 15, 2024 · 1 comment
Closed
1 task done

[Bug] The logo of streaming services cannot be hidden #133

JoeyNoProVN opened this issue Dec 15, 2024 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@JoeyNoProVN
Copy link

JoeyNoProVN commented Dec 15, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

The logo of the media player still shows even though I have disabled that.

Reproduction Steps

Appearance > Show the logo of the media player > Uncheck this but the logo still shows

Expected behavior

No media player logo near thumbnails

Screenshots

Ảnh chụp màn hình 2024-12-15 185749

Device Info

  • Discord Music Presence version: 2.2.8
  • Operating system: Windows 11 Pro, version 24H2, build 26100.2605
  • The media I used: Spotify

Additional context

No response

@JoeyNoProVN JoeyNoProVN added the bug Something isn't working label Dec 15, 2024
@ungive
Copy link
Owner

ungive commented Dec 15, 2024

This is intended, see the discussion in #46.

The setting is under the category "Settings for non-service media players", you can't disable the logo for streaming services, as some of them (TIDAL and Deezer, in the future likely Apple Music and Spotify too) make use of their respective APIs (e.g. the TIDAL API and Deezer API) and usage of those APIs requires branding and backlinks, which I want to adhere to.

If I add an option to hide the logo that might be ok now, but I have plans for Music Presence going forward (see the roadmap) and I don't want to regret it later. Removing the option to hide the logo again in a future version would most certainly upset users, so I'm enforcing it now to save myself any headaches later.

If Discord ever adds the option to put the logo elsewhere, so that it doesn't cover the album art, I'll be sure to incorporate that!

@ungive ungive closed this as completed Dec 15, 2024
@ungive ungive changed the title [Bug] [Bug] The logo of streaming services cannot be hidden Dec 15, 2024
@ungive ungive added the duplicate This issue or pull request already exists label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants