Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the ultimate purpose of this plug-in/fork? #27

Closed
jorisw opened this issue Jan 30, 2024 · 8 comments
Closed

What is the ultimate purpose of this plug-in/fork? #27

jorisw opened this issue Jan 30, 2024 · 8 comments
Labels
question Further information is requested

Comments

@jorisw
Copy link

jorisw commented Jan 30, 2024

Could the README.md describe the purpose of this fork?

We're having performance issues with https://github.com/import-js/eslint-plugin-import, and would like to know how this fork may or may not help us.

@JounQin JounQin added the question Further information is requested label Jan 30, 2024
@JounQin
Copy link
Member

JounQin commented Jan 30, 2024

https://github.com/un-es/eslint-plugin-i/tree/fork-release?tab=readme-ov-file#eslint-plugin-i

A fork of eslint-plugin-import using get-tsconfig to replace tsconfig-paths and heavy typescript under the hood.

See also #24 and #26


Previous PR #11

@JounQin JounQin closed this as completed Jan 30, 2024
@jorisw
Copy link
Author

jorisw commented Jan 30, 2024

Could the intro be expanded to explain which problem it solves?

@JounQin
Copy link
Member

JounQin commented Jan 31, 2024

Does not the quote and related issues/PR make senses for you?

@jorisw
Copy link
Author

jorisw commented Feb 2, 2024

My point is that upon discovering this plug-in on GitHub, the visitor should be made clear what the plug-in hopes to achieve.

The description:

A fork of eslint-plugin-import using get-tsconfig to replace tsconfig-paths and heavy typescript under the hood.

...doesn't do that.

Which problem is addressed by this plug-in/fork ?

@jorisw jorisw changed the title How does this plug-in differ from eslint-plugin-import ? What is the ultimate purpose of this plug-in? Feb 2, 2024
@jorisw jorisw changed the title What is the ultimate purpose of this plug-in? What is the ultimate purpose of this plug-in/fork? Feb 2, 2024
@JounQin
Copy link
Member

JounQin commented Feb 2, 2024

  1. cleanener dependencies
  2. faster speed without heavy TypeScript dependency

And it is been rewritten to be an independent plugin, see also #26, we'll implement many more features as described in #24.

@jorisw
Copy link
Author

jorisw commented Feb 2, 2024

So then I suggest adding to the README and repo description…

This is a drop-in replacement for eslint-plugin-import which is faster, because of less heavy dependency on Typescript, and cleaner dependencies altogether.

@JounQin
Copy link
Member

JounQin commented Feb 2, 2024

Thanks, PR welcome for fork-release branch.

@JounQin JounQin reopened this Feb 2, 2024
@JounQin
Copy link
Member

JounQin commented Feb 11, 2024

Close in favor of #28

@JounQin JounQin closed this as completed Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants