Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependencies #14

Closed
LukeNotable opened this issue Aug 14, 2023 · 4 comments
Closed

Add missing dependencies #14

LukeNotable opened this issue Aug 14, 2023 · 4 comments

Comments

@LukeNotable
Copy link

Trying to use this package for the first time, I got:

Error: Failed to load plugin 'import' declared in '.eslintrc.js': Cannot find module 'array.prototype.flatmap'

Looks like because 2.28.0 added dependencies on:

  • array.prototype.flatmap
  • array.prototype.findlastindex
  • object.fromentries

Which means they should be added to dependencies here too (unless they're being handled some other way).

Workaround is just to add the missing dependency as a dev dependency in my project.

@JounQin
Copy link
Member

JounQin commented Aug 15, 2023

https://github.com/search?q=repo%3Aun-es%2Feslint-plugin-i%20array.prototype.flatmap&type=code

#11

I don't think it is used anywhere in this fork?

@silverwind
Copy link

silverwind commented Oct 19, 2023

Don't include all these ljharb polyfills imho. The original has like 50 extra dependencies because of these useless polyfill packages that are not needed with modern runtimes.

@JounQin
Copy link
Member

JounQin commented Oct 20, 2023

I believe there is nothing to do here, if you still get this error, please provide a minimal but runnable reproduction.

@JounQin JounQin closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2023
@abieler-sap
Copy link

@LukeNotable, try to use version 2.28.1. It helped in our projects to get rid of the flatmap-error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants