Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V14-RC5: Toast notification can't be closed when shown above overlay #16486

Open
bjarnef opened this issue May 29, 2024 · 3 comments
Open

V14-RC5: Toast notification can't be closed when shown above overlay #16486

bjarnef opened this issue May 29, 2024 · 3 comments

Comments

@bjarnef
Copy link
Contributor

bjarnef commented May 29, 2024

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14.0.0-rc5

Bug summary

When toast notification is shown above an overlay it can't be closed via the close button - it does faded away automatically, but could be frustrating when several notifications.

image

It is most likely due the z-indexes.

Specifics

No response

Steps to reproduce

Open an overlay/panel and click an action which trigger notificaiton.

Expected result / actual result

No response

Copy link

Hi there @bjarnef!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@iOvergaard
Copy link
Contributor

Thanks for testing this, @bjarnef. I can confirm this is a bug and needs to be fixed.

@leekelleher
Copy link
Member

For reference, I had a brief investigation into this, with no resolution (yet). The issue is when the <dialog> modal is open, the underlying elements are inaccessible, e.g. it's not a z-index problem.

More info from MDN:

The showModal() method of the HTMLDialogElement interface displays the dialog as a modal, over the top of any other dialogs that might be present. It displays in the top layer, along with a ::backdrop pseudo-element. Interaction outside the dialog is blocked and the content outside it is rendered inert.
https://developer.mozilla.org/en-US/docs/Web/API/HTMLDialogElement/showModal

We may need to review how the toast notifications work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants