Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove server stop action from http and grpc Start() function #26

Open
darkodraskovic opened this issue Jul 24, 2023 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@darkodraskovic
Copy link
Contributor

This files needs to be changed

  • internal/server/http/http.go
  • internal/server/grpc/grpc.go

and the code

	case <-s.Ctx.Done():
		return s.Stop()

moved to internal/server/server.go StopHandler() func.

@darkodraskovic darkodraskovic self-assigned this Aug 1, 2023
@darkodraskovic darkodraskovic added the enhancement New feature or request label Aug 1, 2023
@darkodraskovic
Copy link
Contributor Author

If succesfully solved, we should propagate this upstream to mainflux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant