Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Links should expose valid port assigned to ingress controller #88

Open
ullbergm opened this issue Jul 10, 2024 · 1 comment
Open
Labels
enhancement feature/configuration Feature related to application configuration
Milestone

Comments

@ullbergm
Copy link
Owner

Feature Request

Describe the Feature Request

Currently automatically generated links point into 443 port (via https prefix). If there's more ingress controllers, they use different ports. So some links are incorrect, because misses valid port

Describe Preferred Solution

Links should be created with valid port. As we can have multiple ingress controllers supporting the same ingress, we don't know which port to choose, so the easiest way would be to allow to override default 443 port via annotation like:

startpunkt.ullberg.us/port: "2000"

Describe Alternatives

  • Can we figure out the port based on the ingress controller (and how does this translate to other ingress types like Routes or Gateway-API?)?
  • What about a global port override?

Related Code

Additional Context

Based on @Marx2 request for Hajimari (toboshii/hajimari/issues/113)
Also @PrymalInstynct request for Hajimari (toboshii/hajimari/issues/28)

@ullbergm ullbergm modified the milestones: v2.0, v1.0 Jul 12, 2024
@ullbergm ullbergm added the feature/configuration Feature related to application configuration label Jul 12, 2024
@ullbergm ullbergm modified the milestones: v1.0, v2.0 Jul 19, 2024
@Marx2
Copy link

Marx2 commented Nov 27, 2024

maybe sth like:
hajimari.io/port-override: 8080

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature/configuration Feature related to application configuration
Projects
None yet
Development

No branches or pull requests

2 participants