diff --git a/api/compliance/helpers.py b/api/compliance/helpers.py index 4704021ba..d152345be 100644 --- a/api/compliance/helpers.py +++ b/api/compliance/helpers.py @@ -41,13 +41,11 @@ def get_compliance_site_case(pk): def case_meets_conditions_for_compliance(case: Case): if case.case_type.id == CaseTypeEnum.SIEL.id: if settings.FEATURE_SIEL_COMPLIANCE_ENABLED: - if ( - Good.objects.filter( - goods_on_application__application_id=case.id, - control_list_entries__rating__regex=COMPLIANCE_CASE_ACCEPTABLE_GOOD_CONTROL_CODES, - goods_on_application__licence__quantity__isnull=False, - ).exists() - ): + if Good.objects.filter( + goods_on_application__application_id=case.id, + control_list_entries__rating__regex=COMPLIANCE_CASE_ACCEPTABLE_GOOD_CONTROL_CODES, + goods_on_application__licence__quantity__isnull=False, + ).exists(): return True return False elif case.case_type.id in [CaseTypeEnum.OIEL.id, CaseTypeEnum.OICL.id, *CaseTypeEnum.OPEN_GENERAL_LICENCE_IDS]: diff --git a/api/compliance/tests/test_compliance_creation.py b/api/compliance/tests/test_compliance_creation.py index f50fc013b..b594c72d7 100644 --- a/api/compliance/tests/test_compliance_creation.py +++ b/api/compliance/tests/test_compliance_creation.py @@ -78,9 +78,7 @@ def tests_siel_good_control_code(self, control_code, exists): def tests_siel_no_compliance_feature_flag_off(self): case = self.create_standard_application_case(self.organisation) - good = GoodFactory( - organisation=self.organisation, is_good_controlled=True, control_list_entries=["ML22"], - ) + good = GoodFactory(organisation=self.organisation, is_good_controlled=True, control_list_entries=["ML22"],) GoodOnLicenceFactory( good=GoodOnApplicationFactory(application=case, good=good), licence=LicenceFactory(case=case),