Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customization (making domain + name your own) #3

Open
SEAPUNK opened this issue May 15, 2018 · 2 comments
Open

Customization (making domain + name your own) #3

SEAPUNK opened this issue May 15, 2018 · 2 comments

Comments

@SEAPUNK
Copy link
Contributor

SEAPUNK commented May 15, 2018

I just noticed that some public assets have your instance's name and URL hardcoded into them, e.g. https://github.com/6f7262/kipp/blob/master/default/public/sharex

Especially with the Dockerfile setup, I think it'd be cool if there was a way to rebuild those assets with a custom domain name and app name (you know, like how mixtape.moe runs on Pomf, but their instance isn't called Pomf)

@uhthomas
Copy link
Owner

uhthomas commented May 15, 2018 via email

@SEAPUNK
Copy link
Contributor Author

SEAPUNK commented May 16, 2018

Hmm, not entirely sure yet. Right now my current idea is to have the entire public directory be templates and on startup loaded (and compiled with given config) into memory, which would eat into startup time, but would make it reliable across upgrades and changes in configs...

Alternatively, kipp could have a one-time "build" command that builds and writes public assets from templates, and the docker image would have a script that does that on startup every time before actually starting kipp.

I'll let you know if I have a properly good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants