-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customization (making domain + name your own) #3
Comments
I had noticed that as well. It's also baked into the HTML. I was
considering using go generate to build these assets but it would get quite
complicated. The files can currently be edited manually but do you have any
suggestions?
…On Wed, 16 May 2018, 00:33 ivan k, ***@***.***> wrote:
I just noticed that some public assets have your instance's name and URL
hardcoded into them, e.g.
https://github.com/6f7262/kipp/blob/master/default/public/sharex
Especially with the Dockerfile setup, I think it'd be cool if there was a
way to rebuild those assets with a custom domain name and app name (you
know, like how mixtape.moe runs on Pomf, but their instance isn't called
Pomf)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJTCtbcRwXRdwaW5SSMdPnDrVn55NJMbks5ty2XDgaJpZM4UAbZc>
.
|
Hmm, not entirely sure yet. Right now my current idea is to have the entire public directory be templates and on startup loaded (and compiled with given config) into memory, which would eat into startup time, but would make it reliable across upgrades and changes in configs... Alternatively, kipp could have a one-time "build" command that builds and writes public assets from templates, and the docker image would have a script that does that on startup every time before actually starting kipp. I'll let you know if I have a properly good idea. |
I just noticed that some public assets have your instance's name and URL hardcoded into them, e.g. https://github.com/6f7262/kipp/blob/master/default/public/sharex
Especially with the Dockerfile setup, I think it'd be cool if there was a way to rebuild those assets with a custom domain name and app name (you know, like how mixtape.moe runs on Pomf, but their instance isn't called Pomf)
The text was updated successfully, but these errors were encountered: