From 571c071b21ede1d830ae6f8ce4d0d09cc8c8c6af Mon Sep 17 00:00:00 2001 From: imarios Date: Tue, 4 Dec 2018 22:22:12 -0800 Subject: [PATCH] Addressing code review comments --- dataset/src/main/scala/frameless/TypedDataset.scala | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dataset/src/main/scala/frameless/TypedDataset.scala b/dataset/src/main/scala/frameless/TypedDataset.scala index 3528a3bc..a9a10bc6 100644 --- a/dataset/src/main/scala/frameless/TypedDataset.scala +++ b/dataset/src/main/scala/frameless/TypedDataset.scala @@ -110,7 +110,8 @@ class TypedDataset[T] protected[frameless](val dataset: Dataset[T])(implicit val (c, i) <- columns.toList[UntypedExpression[T]].zipWithIndex } yield new Column(c.expr).as(s"_${i+1}") - // Workaround to SPARK-20346. The alternative is to allow the result to be Vector(null) for empty DataFrames. + // Workaround to SPARK-20346. One alternative is to allow the result to be Vector(null) for empty DataFrames. + // Another one would be to return an Option. val filterStr = ( for { (c, i) <- underlyingColumns.zipWithIndex