From 93f60d3716b8c4d4fbc3f92bc6c2ddb64cd08f5f Mon Sep 17 00:00:00 2001 From: Ganeshwara Hananda Date: Fri, 22 Jan 2021 17:13:14 +0000 Subject: [PATCH 1/4] Add read secondary --- protobuf/transaction.proto | 1 + 1 file changed, 1 insertion(+) diff --git a/protobuf/transaction.proto b/protobuf/transaction.proto index 7e742c4d..524d1038 100644 --- a/protobuf/transaction.proto +++ b/protobuf/transaction.proto @@ -67,6 +67,7 @@ message Transaction { enum Type { READ = 0; WRITE = 1; + READ_SECONDARY = 2; } message Open { From 68cb20d6e14df0acae1a6aed011562440ce3aa54 Mon Sep 17 00:00:00 2001 From: Ganeshwara Hananda Date: Mon, 25 Jan 2021 17:35:18 +0000 Subject: [PATCH 2/4] Allow performing reads to secondary replica. Update stale terminology --- protobuf/cluster/database.proto | 2 +- protobuf/options.proto | 3 +++ protobuf/transaction.proto | 1 - 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/protobuf/cluster/database.proto b/protobuf/cluster/database.proto index 27e38196..379c0de8 100644 --- a/protobuf/cluster/database.proto +++ b/protobuf/cluster/database.proto @@ -34,7 +34,7 @@ message Database { message Replica { string address = 1; string database = 2; - bool is_leader = 3; + bool is_primary = 3; int64 term = 4; } } diff --git a/protobuf/options.proto b/protobuf/options.proto index f5dad929..16604efa 100644 --- a/protobuf/options.proto +++ b/protobuf/options.proto @@ -44,4 +44,7 @@ message Options { oneof schema_lock_acquire_timeout_opt { int32 schema_lock_acquire_timeout_millis = 6; } + oneof primary_replica_opt { + bool primary_replica = 6; + } } diff --git a/protobuf/transaction.proto b/protobuf/transaction.proto index 524d1038..7e742c4d 100644 --- a/protobuf/transaction.proto +++ b/protobuf/transaction.proto @@ -67,7 +67,6 @@ message Transaction { enum Type { READ = 0; WRITE = 1; - READ_SECONDARY = 2; } message Open { From ada1b4c52fcf08b1b7adaea1270192c67067f5ac Mon Sep 17 00:00:00 2001 From: Ganeshwara Hananda Date: Mon, 25 Jan 2021 19:05:35 +0000 Subject: [PATCH 3/4] Update field number --- protobuf/options.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/protobuf/options.proto b/protobuf/options.proto index 16604efa..f9547176 100644 --- a/protobuf/options.proto +++ b/protobuf/options.proto @@ -45,6 +45,6 @@ message Options { int32 schema_lock_acquire_timeout_millis = 6; } oneof primary_replica_opt { - bool primary_replica = 6; + bool primary_replica = 7; } } From 6d5a5e1b58d91fd001e06b2820363e7194f7fd3f Mon Sep 17 00:00:00 2001 From: Ganeshwara Hananda Date: Tue, 26 Jan 2021 12:37:09 +0000 Subject: [PATCH 4/4] Update field name --- protobuf/options.proto | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/protobuf/options.proto b/protobuf/options.proto index f9547176..7f4b4525 100644 --- a/protobuf/options.proto +++ b/protobuf/options.proto @@ -44,7 +44,7 @@ message Options { oneof schema_lock_acquire_timeout_opt { int32 schema_lock_acquire_timeout_millis = 6; } - oneof primary_replica_opt { - bool primary_replica = 7; + oneof allow_secondary_replica_opt { + bool allow_secondary_replica = 7; } }