Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support formatting in VS Code #70

Closed
torhovland opened this issue Sep 20, 2022 · 5 comments
Closed

Support formatting in VS Code #70

torhovland opened this issue Sep 20, 2022 · 5 comments
Labels
epic: usability-end-users Relates to the usability of Topiary for endusers to use Topiary as a generic "good enough" formatter P3 minor: not priorized type: feature request

Comments

@torhovland
Copy link
Member

TOML would be a good candidate for this, as it is a simple language to support (see #69), and because it isn't covered by widely used formatters already (toml-lang/toml#532).

@torhovland torhovland added type: feature request P2 major: an upcoming release labels Sep 20, 2022
@aspiwack
Copy link
Member

I don't understand what this issue is about. Can you say more?

@torhovland
Copy link
Member Author

The idea is to be able to run our formatter on the "Format on Save" feature in VS Code. This means we need a VS Code extension that registers the formatter. It would be nice if we could hook into an existing extension, and just configure the path (and command line args) to our formatter, but I don't know if an extension like that exists.

@aspiwack
Copy link
Member

I see.

This is not something that is required for a first release. Let's think about extensions for editors in a second step.

@torhovland
Copy link
Member Author

Agreed. This was meant more as a validation of the engine for practical use. For example, we may have to support supplying the input path as a command line argument, not just pipe from stdin.

@torhovland torhovland added P3 minor: not priorized and removed P2 major: an upcoming release labels Sep 21, 2022
@ErinvanderVeen ErinvanderVeen added the epic: usability-end-users Relates to the usability of Topiary for endusers to use Topiary as a generic "good enough" formatter label Sep 28, 2023
@nbacquey
Copy link
Member

Superseded by #655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic: usability-end-users Relates to the usability of Topiary for endusers to use Topiary as a generic "good enough" formatter P3 minor: not priorized type: feature request
Projects
None yet
Development

No branches or pull requests

4 participants