Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return exit codes #100

Closed
facundominguez opened this issue Feb 28, 2017 · 2 comments
Closed

return exit codes #100

facundominguez opened this issue Feb 28, 2017 · 2 comments

Comments

@facundominguez
Copy link
Member

facundominguez commented Feb 28, 2017

Currently, sparkle arranges for main to be called but it ignores the returned exit code. This value should be somehow propagated to Java to give it an opportunity to do proper clean up.

The main use case is cleaning up temporary files produced by spark when there are test failures in test suites that rehearse sparkle.

Related to this: it has been noted elsewhere that the main() function that sparkle calls during bootstrap never returns control to the caller.

@facundominguez
Copy link
Member Author

Probably, it should be done by throwing a Java exception before returning control to the caller.

@facundominguez
Copy link
Member Author

Propagating exceptions to spark has been implemented in #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant