Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table aws_trusted_advisor_check_summary #1831

Closed
khushboo9024 opened this issue Jul 11, 2023 · 8 comments · Fixed by #1978
Closed

Add table aws_trusted_advisor_check_summary #1831

khushboo9024 opened this issue Jul 11, 2023 · 8 comments · Fixed by #1978
Assignees
Labels
enhancement New feature or request new table New table request

Comments

@khushboo9024
Copy link
Contributor

References
https://pkg.go.dev/github.com/aws/[email protected]/service/support#Support.DescribeTrustedAdvisorCheckSummaries

Note: This table is required to check if AWS Trusted Advisor is enabled with zero checks in alarm state.

@khushboo9024 khushboo9024 added enhancement New feature or request new table New table request labels Jul 11, 2023
@rajlearner17 rajlearner17 self-assigned this Jul 24, 2023
@cbruno10
Copy link
Contributor

What is the exact resource this table returns info for? Is it a check summary?

@qualymetrics
Copy link

Hello, we need to collect possible public repositories that may contain Access Key and Secret Key and we identified that the item “Exposed Access Keys” via AWS Trusted Advisor could provide this information. Would it be possible to add this table to steampipe?

Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale No recent activity has been detected on this issue/PR and it will be closed label Nov 12, 2023
@JohannesKonings
Copy link

Maybe the table can contain all checks with their status. The calls can be look similar to this: https://gist.github.com/maemichi-monosense/60627feed80a1d13bc08c35a6e6759aa
The summary than could be created via SQL

@github-actions github-actions bot removed the stale No recent activity has been detected on this issue/PR and it will be closed label Nov 16, 2023
@ParthaI ParthaI changed the title Add table aws_trusted_advisor Add table aws_trusted_advisor_check_summary Nov 21, 2023
@ParthaI ParthaI linked a pull request Nov 27, 2023 that will close this issue
@ParthaI
Copy link
Contributor

ParthaI commented Nov 27, 2023

@khushboo9024 @JohannesKonings, I've submitted a PR to address this issue. Would you kindly test it in the PR branch issue-1831?

I wasn't able to personally test the pull request because we lack a business, Enterprise On-Ramp, or Enterprise Support plan, which is required for making the DescribeTrustedAdvisorCheckSummaries API call.

Here are the steps to check out the PR branch:

  1. Clone the repository: git clone https://github.com/turbot/steampipe-plugin-aws.git
  2. Navigate to the repository: cd steampipe-plugin-aws
  3. Switch to the issue-1831 branch: git checkout issue-1831
  4. Execute the make command.
  5. Run your query.

Thank you!

@JohannesKonings
Copy link

The tests for my use case looks good. I got the same numbers for status like the are shown in the AWS console.

@ParthaI
Copy link
Contributor

ParthaI commented Nov 28, 2023

Thank you, @JohannesKonings, for testing the PR branch and sharing your feedback.

Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale No recent activity has been detected on this issue/PR and it will be closed label Jan 27, 2024
@ParthaI ParthaI removed the stale No recent activity has been detected on this issue/PR and it will be closed label Jan 28, 2024
misraved added a commit that referenced this issue Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new table New table request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants