Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dot print #24

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Fix dot print #24

merged 4 commits into from
Jan 18, 2024

Conversation

SiccoVerwer
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Jan 18, 2024

Unit Test Results

1 files  1 suites   0s ⏱️
4 tests 4 ✔️ 0 💤 0
7 runs  7 ✔️ 0 💤 0

Results for commit 2fecb90.

♻️ This comment has been updated with latest results.

@TCatshoek TCatshoek merged commit ad2a819 into main Jan 18, 2024
3 checks passed
@TCatshoek TCatshoek deleted the fix_dot_print branch January 18, 2024 17:00
@hwalinga
Copy link
Collaborator

I think the node numbering bookkeeping should also be done by the mem_store as suggested in #23. Then it will automatically be fixed for the split routines.

Now node numbering relies on inputdata::add_trace_to_apta that keeps a increasing int node_number in its class members. However, split routines just call mem_store::create_node (just like done in inputdata::add_trace_to_apta). If the mem_store maintains the node_number instead it will automatically add the correct unique increasing integer identifier when the mem_store::create_node routine is called. This will apply correct numbering during splitting and apta creation and fix the problem for good.

#23 Also suggests doing this for the unique increasing integer identifiers for traces and tails.

hwalinga pushed a commit to hwalinga/FlexFringe that referenced this pull request Jul 3, 2024
* removed renumbering (still need to correct for splits) and fixed printing dot files

* Add smoke test for dot output

* Add a method to state_merger to print dot output to a stream rather than a file to aid in testing.

---------

Co-authored-by: sverwer <[email protected]>
Co-authored-by: Tom Catshoek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants