From ed53561d92c7177d8495cb3fa21d1ab9f2cb44ec Mon Sep 17 00:00:00 2001 From: tsutsu3 Date: Mon, 23 Dec 2024 20:20:28 +0900 Subject: [PATCH] Revert "chore(pr): enable quality gate wait in SonarQube (#68)" This reverts commit 865599956cc2aabf1b089dfd5f04373dbdf32a30. --- .github/workflows/sonar-qube.yaml | 3 +-- sonar-project.properties | 5 +---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/.github/workflows/sonar-qube.yaml b/.github/workflows/sonar-qube.yaml index 4396c769..b6c8b1b0 100644 --- a/.github/workflows/sonar-qube.yaml +++ b/.github/workflows/sonar-qube.yaml @@ -33,5 +33,4 @@ jobs: uses: SonarSource/sonarqube-scan-action@v4 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # Needed to get PR information, if any - SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} - continue-on-error: true # TODO: Remove after expanding test cases to enforce quality gate checks \ No newline at end of file + SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} \ No newline at end of file diff --git a/sonar-project.properties b/sonar-project.properties index 2023ed20..94afaeed 100644 --- a/sonar-project.properties +++ b/sonar-project.properties @@ -17,7 +17,4 @@ sonar.sourceEncoding=UTF-8 sonar.exclusions=test/**/*_test.mocks.dart,lib/**/*.g.dart # coverage -sonar.dart.lcov.reportPaths=coverage/lcov.info - -# TODO: Remove after expanding test cases to enforce quality gate checks -sonar.qualitygate.wait=true \ No newline at end of file +sonar.dart.lcov.reportPaths=coverage/lcov.info \ No newline at end of file