-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix of the adaption to Windows #163
Comments
I'm not sure what you mean about code differing, but I do note that the line |
Windows support remains unofficial, but happy to continue to merge PRs |
I wanted to do a pull request. I forked the current repository of StaticCompiler. I compared the file StaticCompiler.jl in the forked repository and the file StaticCompiler.jl from the current package. They should be the same, I thought. The bug fix I have planned with the /c instead \c is meanful in the file StaticCompiler.jl of the current package. But in the forked repository there is no line mentioning
In the forked repository:
|
The only problem why StaticCompiler does still not work in Windows is, that the clang - provided in the artifact of the package Clang_jll (used by StaticCompiler)) - does not work in Windows. There are versions of clang.exe that do work in Windows. One has to integrate or suggest such a clang-version into Clang_jll. The cmd /c is only a workaround such that one can use a clang that is locally installed. |
Ah, it looks like what you're referring to as the code in the "current package" is prior to pr #160 from @daizutabi that got CI running on Windows. We can just make a new release then, and see if that solves the problem As an aside, it's not clear to me that the |
Yes, the
|
Interesting. The windows CI that @daizutabi addes seems to be passing without it, but you're welcome to PR it back in as long as that doesn't break CI. |
Thank you for incorporating the pull request.
There is still one line that causes that StaticCompiler does not work in Windows:
in
generate_executable():
The line
``cmd \c clang
is wrong.
It must be:
``cmd /c clang
(I tried to do a pull request with the fix
But when forking the code in StaticCompiler.jl differed from the one in the curent package ?!)
The text was updated successfully, but these errors were encountered: