Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake improvements? #9

Open
Anton3 opened this issue Dec 19, 2019 · 1 comment
Open

CMake improvements? #9

Anton3 opened this issue Dec 19, 2019 · 1 comment

Comments

@Anton3
Copy link
Contributor

Anton3 commented Dec 19, 2019

In order to be able to use RansacLib as a modern CMake library, I had to:

  1. Move RS_ROOT/RansacLib directory to RS_ROOT/include/RansacLib, because otherwise I'd get examples, LICENSE and README in the include directory
  2. Delete CMakeLists.txt and write my own, which says:
project(RansacLib LANGUAGES CXX)
add_library(RansacLib INTERFACE)
target_include_directories(RansacLib INTERFACE RansacLib/include)
target_compile_features(RansacLib INTERFACE cxx_std_11)

What about including this "out of the box"? CmakeLists.txt could create the header-only CMake library by default, and build examples when passed some additional flag.

@tsattler
Copy link
Owner

tsattler commented Jan 8, 2020

Do you want to create a pull request for this? Would be happy to merge this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants