Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storing settings better #37

Closed
trys opened this issue Jan 15, 2019 · 0 comments
Closed

Storing settings better #37

trys opened this issue Jan 15, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@trys
Copy link
Owner

trys commented Jan 15, 2019

In readiness for languages, better theming, markdown and more (referenced in #35), we need to store settings in a better way than localStorage. Given idb is in place, a new table is probably the best option.

A migration will be required for the new table, key names decided, and defaults set. Any existing settings should be migrated - that should just be theme for now. This can be run in the initial table migration.

Once created, the settings page can be hooked up to the new table.

@trys trys added the enhancement New feature or request label Jan 15, 2019
@trys trys self-assigned this Jan 15, 2019
@trys trys closed this as completed Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant