Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Project shows "Build Failing" badge in main README and on npm #2604

Closed
brandonlenz opened this issue Sep 29, 2023 · 0 comments · Fixed by #2777
Closed

[fix] Project shows "Build Failing" badge in main README and on npm #2604

brandonlenz opened this issue Sep 29, 2023 · 0 comments · Fixed by #2777
Assignees
@werdnanoslen
Labels
good first infra issue Good for newcomers with infra and CI affinities good first issue Good for newcomers Hacktoberfest requires Truss type: bug Something isn't working like it's supposed to

Comments

@brandonlenz
Copy link
Contributor

brandonlenz commented Sep 29, 2023 •
edited
Loading

On the npm page and on our README, there is a circleci build-failing badge. We've migrated away from circle ci (completely, mostly?) investigate and remove or replace the badge with a suitable alternative

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/trussworks/react-uswds#trussworksreact-uswds
  2. Go to https://www.npmjs.com/package/@trussworks/react-uswds?activeTab=readme
  3. See the badge

Expected behavior

If there is a build status we would like to track with a badge, it should not be failing and should be related to a job we are currently using

Note: Since CircleCI is internal to Truss, this may require someone with Truss CircleCI credentials to investigate
@brandonlenz brandonlenz added type: bug Something isn't working like it's supposed to good first issue Good for newcomers good first infra issue Good for newcomers with infra and CI affinities requires Truss labels Sep 29, 2023
@werdnanoslen werdnanoslen linked a pull request Feb 23, 2024 that will close this issue
docs: removed circleci references #2777
Merged
@werdnanoslen werdnanoslen mentioned this issue Feb 23, 2024
Merged
@werdnanoslen werdnanoslen self-assigned this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@werdnanoslen werdnanoslen

Labels
good first infra issue Good for newcomers with infra and CI affinities good first issue Good for newcomers Hacktoberfest requires Truss type: bug Something isn't working like it's supposed to
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: removed circleci references trussworks/react-uswds
2 participants
@werdnanoslen @brandonlenz