Features need to be supported

[CarlChaoCarl]

Hello,

Because the development of the wallet CLI is needed, there are additional RPC requests that need to be evaluated for support and implementation. The specific requests are as follows:

• ClearContractABI - Clear Contract ABI
• DeployContract - Deploy Smart Contract
• TriggerContract - Trigger Contract
• TriggerConstantContract - Trigger Constant Contract
• EstimateEnergy - Estimate Energy
• ExchangeCreate - Create Token Exchange
• ExchangeInject - Inject Tokens into Exchange
• ExchangeTransaction - Execute Token Exchange Transaction
• ExchangeWithdraw - Withdraw Tokens from Exchange
• GetBlock - Get Block Information
• GetBlockByIdOrNum - Get Block Information by Block ID or Block Number
• GetContractInfo - Get Detailed Contract Information
• GetMarketOrderByAccount - Get Market Orders by Account
• GetMarketOrderById - Get Market Order by Order ID
• GetMarketOrderListByPair - Get Market Orders List by Token Pair
• GetMarketPairList - Get List of Market Trading Pairs
• GetMarketPriceByPair - Get Market Price by Trading Pair
• GetTotalTransaction - Get Total Number of Transactions
• GetTransactionCountByBlockNum - Get Transaction Count in a Block
• GetTransactionsFromThis - Get Transactions from a Specific Address
• GetTransactionsToThis - Get Received Transactions to a Specific Address
• ListExchangesPaginated - Get Paginated Exchange List
• ListShieldedTRC20Note - List Shielded TRC20 Notes
• ListProposalsPaginated - Get Paginated Proposal List
• MarketCancelOrder - Cancel Market Order
• MarketSellAsset - Sell Market Asset
• ScanShieldedTRC20NoteByIvk - Scan Shielded TRC20 Token Records by IVK
• ScanShieldedTRC20NoteByOvk - Scan Shielded TRC20 Token Records by OVK
• SendShieldedTRC20Coin - Send Shielded TRC20 Token
• SendShieldedTRC20CoinWithoutAsk - Send Shielded TRC20 Token (Without User Confirmation)
• SetShieldedTRC20ContractAddress - Set Shielded TRC20 Contract Address
• TransferAsset - Perform Asset Transfer
• UpdateEnergyLimit - Update Contract Energy Limit
• UpdateSetting - Update Contract Settings

Please let me know how these can be supported and planned.

[0xbigapple]

I think it is necessary to support these RPC requests, I am willing to evaluate and then implement this requirement.

[0xbigapple]

Thank you for your suggested requirements. After discussion, we will support the following RPC list by the end of the month.

• ClearContractABI 
 
• DeployContract
• ExchangeCreate
• ExchangeInject
• ExchangeTransaction
• ExchangeWithdraw
• GetBlock
 
• GetBlockByIdOrNum - GetBlockById、GetBlockByNum support
• GetContractInfo

• GetMarketOrderByAccount
• GetMarketOrderById
• GetMarketOrderListByPair
• GetMarketPairList
• GetMarketPriceByPair
• GetTotalTransaction
• GetTransactionCountByBlockNum
•  ListExchangesPaginated
• ListProposalsPaginated
• MarketCancelOrder
• MarketSellAsset
• TransferAsset
• UpdateEnergyLimit
• UpdateSetting


Other methods followed are not suitable for support in Trident due to reasons such as block scanning, and we may discuss splitting your requirements and implementing them in the next phase.

•  GetTransactionsFromThis
• GetTransactionsToThis
• ListShieldedTRC20Note
• ScanShieldedTRC20NoteByIvk
• ScanShieldedTRC20NoteByOvk

• SendShieldedTRC20Coin
• SendShieldedTRC20CoinWithoutAsk
• SetShieldedTRC20ContractAddress

[CarlChaoCarl]

The message SmartContract structure in trident and java-tron lacks a version field
, please confirm that there is a follow-up plan

[0xbigapple]

The message SmartContract structure in trident and java-tron lacks a version field , please confirm that there is a follow-up plan

We will support it simultaneously.

[CarlChaoCarl]

I found an issue with the implementation logic of getProposalById in Trident.

if (proposal.getApprovalsCount() == 0) {
    throw new IllegalException();
}

This code means that the Approvals of a proposal must not be zero; otherwise, an exception will be thrown.

However, for newly created proposals, the Approvals count is 0 by default, which results in the inability to retrieve newly created proposals.

Please confirm and arrange a fix plan.

[0xbigapple]

I found an issue with the implementation logic of getProposalById in Trident.

if (proposal.getApprovalsCount() == 0) {
throw new IllegalException();
}
This code means that the Approvals of a proposal must not be zero; otherwise, an exception will be thrown.

However, for newly created proposals, the Approvals count is 0 by default, which results in the inability to retrieve newly created proposals.

Please confirm and arrange a fix plan.

Thank you for your suggestion. We will fix this issue in the next release.