Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For more security spongycastle -> bouncycastle #3087

Closed
Neustradamus opened this issue Apr 12, 2020 · 14 comments · Fixed by #3919
Closed

For more security spongycastle -> bouncycastle #3087

Neustradamus opened this issue Apr 12, 2020 · 14 comments · Fixed by #3919
Assignees
Labels
type: Enhancement minor enhancement

Comments

@Benson0224 Benson0224 added the type: Enhancement minor enhancement label Apr 13, 2020
@Benson0224
Copy link
Contributor

@Neustradamus could you please list the potential risk or potential attack if we are still on the old spongycastle?

@Neustradamus
Copy link
Author

@Benson0224: Thanks for your comment!
Currently Bouncy Castle last version is 1.65 and Spongy Castle last version is 1.58.
Spongy Castle is a fork of Bouncy Castle.
Please look previous links :)

Since several years, a lot of projects have already moved from Spongy Castle to Bouncy Castle because the project is dead.

You can see discussion "34" in https://github.com/rtyley/spongycastle/issues.

@Benson0224
Copy link
Contributor

@Neustradamus Thanks for your clarification.

Checked with Team, replace Spongy Castle with Bouncy Castle is not easy and it affects multiple modules, We will add it in our to-do list and start soon, at the same time, we will keep this issue here, and update the progress timely.

@Benson0224
Copy link
Contributor

Spongy Castle will not be maintained anymore. check detail at:
rtyley/spongycastle#34

@Neustradamus
Copy link
Author

@Benson0224: Yes, it is for this I have requested this change because currently there are security problems.

@Neustradamus
Copy link
Author

@Benson0224
Copy link
Contributor

@Neustradamus checked with the team, it is already on our to-do list. however this change is a huge change, it cannot be done within a short time. and currently, we are busy with other urgent tasks. we will update this issue once we got any progress. thanks.

@Neustradamus
Copy link
Author

@Benson0224: Thanks for your reply!
Please note that this is a security problem, it is important ;)

@Neustradamus
Copy link
Author

@Benson0224, @shydesky, @Federico2014: Any news?

@que1414
Copy link

que1414 commented Jul 1, 2021

Duplicate of #

@Federico2014
Copy link
Contributor

@Benson0224 @Neustradamus The bouncy castle library will be updated in release 4.3.0, please refer to #3919

@Federico2014 Federico2014 linked a pull request Jul 20, 2021 that will close this issue
@Neustradamus
Copy link
Author

@Federico2014: Good job, thanks!

@Benson0224
Copy link
Contributor

Thanks for your support to java-tron.
This issue will be closed as it is already implemented in https://github.com/tronprotocol/java-tron/releases/tag/GreatVoyage-v4.3.0

@Neustradamus
Copy link
Author

Neustradamus commented Aug 6, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: Enhancement minor enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants