Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface tension validation #714

Draft
wants to merge 480 commits into
base: main
Choose a base branch
from
Draft

Surface tension validation #714

wants to merge 480 commits into from

Conversation

svchb
Copy link
Collaborator

@svchb svchb commented Jan 30, 2025

Validation cases for surface tension models based on #584

svchb added 30 commits October 10, 2024 12:52
@svchb
update
95be0e9
@svchb
cleanup
4b87c7c
@svchb
include in test run
8c72576
@svchb
remove redundancy
782f9de
@svchb
Merge branch 'main' into morris_surface_tension
fa45125
@svchb
Merge branch 'main' into generalize_surface_normal_calc
8946b45
@svchb
Merge remote-tracking branch 'origin/prepare_for_1.11' into generaliz…
ddfab3e 
…e_surface_normal_calc
@svchb
Merge branch 'generalize_surface_normal_calc' into morris_surface_ten…
f266682 
…sion
@svchb
Merge remote-tracking branch 'origin/prepare_for_1.11' into fix_obs_f…
b0d24cc 
…or_free_surface
@svchb
Merge branch 'fix_obs_for_free_surface' into morris_surface_tension
ff75223
@svchb
Merge branch 'main' into add_ideal_gas
796b1d1
@svchb
Merge remote-tracking branch 'origin/prepare_for_1.11' into add_ideal…
c402975 
…_gas
@svchb
Merge remote-tracking branch 'origin/add_ideal_gas' into add_ideal_gas
83514da
@svchb
Merge branch 'add_ideal_gas'
e94218c 
Conflicts:
	examples/fluid/dam_break_oil_film_2d.jl
	src/schemes/fluid/weakly_compressible_sph/density_diffusion.jl
	src/schemes/fluid/weakly_compressible_sph/rhs.jl
	src/schemes/fluid/weakly_compressible_sph/state_equations.jl
	src/schemes/fluid/weakly_compressible_sph/system.jl
	src/visualization/write2vtk.jl
@svchb
revert
6f5ca10
@svchb
fix tests
5e688d2
@svchb
fix
7557879
@svchb
Merge remote-tracking branch 'origin/morris_surface_tension' into mor…
83ba221 
…ris_surface_tension
@svchb
Merge branch 'fix_obs_for_free_surface' into morris_surface_tension
b4f7a2e
@svchb
fix test
8294aa9
@svchb
Merge branch 'fix_obs_for_free_surface' into morris_surface_tension
b5663f5
@svchb
Merge branch 'main' into generalize_surface_normal_calc
76e5354
@svchb
Merge branch 'main' into add_ideal_gas
f267d43
@svchb
fix test
bdd6756
@svchb
Merge branch 'fix_obs_for_free_surface' into morris_surface_tension
d8f9b1a
@svchb
Merge branch 'main' into fix_obs_for_free_surface
cde7990
@svchb
Merge branch 'main' into morris_surface_tension
6c93850
@svchb
update
1191c3a
@svchb
fix division by zero
c3683e9
@svchb
fix the test
1ec7eac
svchb added 24 commits January 28, 2025 15:27
@svchb
add comment
face89a
@svchb
Merge branch 'generalize_surface_normal_calc' into morris_surface_ten…
540ee3f 
…sion
@svchb
remove ideal_neighbor()
1832335
@svchb
Merge branch 'generalize_surface_normal_calc' into morris_surface_ten…
6f1e8a9 
…sion
@svchb
format
97f3b06
@svchb
format
3d1006a
@svchb
typo
0796b3f
@svchb
Merge branch 'generalize_surface_normal_calc' into morris_surface_ten…
bba3bd8 
…sion
@svchb
fix tests
d4d4067
@svchb
format
523c5e2
@svchb
add missing docs
abcd3ac
@svchb
Merge branch 'generalize_surface_normal_calc' into morris_surface_ten…
1771434 
…sion
@svchb
cleanup
f4088c0
@svchb
only initialize necessary values
65101db
@svchb
Merge branch 'generalize_surface_normal_calc' of github.com:svchb/Tri…
a878534 
…xiParticles.jlOpen into generalize_surface_normal_calc
@svchb
Merge branch 'generalize_surface_normal_calc' into morris_surface_ten…
c2f675e 
…sion
@svchb
fix test
648744e
@svchb
fix examples
e31e843
@svchb
Merge branch 'main' into generalize_surface_normal_calc
4a9e333
@svchb
Merge branch 'generalize_surface_normal_calc' into morris_surface_ten…
42b24ba 
…sion
@svchb
Merge branch 'main' into morris_surface_tension
767eb9b
@svchb
format
27b5089
@svchb
fix tests
fc73ebf
@svchb
typo
fddf47a
@svchb svchb self-assigned this Jan 30, 2025
@svchb svchb marked this pull request as draft January 30, 2025 15:31
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 42.96875% with 146 lines in your changes missing coverage. Please review.

Project coverage is 68.77%. Comparing base (2540f08) to head (ecc1e7d).

Files with missing lines Patch % Lines
src/schemes/fluid/surface_normal_sph.jl 34.00% 66 Missing ⚠️
src/schemes/fluid/surface_tension.jl 15.38% 22 Missing ⚠️
src/visualization/write2vtk.jl 0.00% 18 Missing ⚠️
src/schemes/fluid/fluid.jl 28.57% 10 Missing ⚠️
...rc/schemes/fluid/entropically_damped_sph/system.jl 20.00% 8 Missing ⚠️
src/general/semidiscretization.jl 65.00% 7 Missing ⚠️
src/preprocessing/particle_packing/system.jl 0.00% 6 Missing ⚠️
...rc/schemes/fluid/weakly_compressible_sph/system.jl 70.58% 5 Missing ⚠️
src/general/system.jl 66.66% 2 Missing ⚠️
src/schemes/boundary/system.jl 90.47% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #714      +/-   ##
==========================================
- Coverage   70.53%   68.77%   -1.76%     
==========================================
  Files          96       96              
  Lines        5976     6120     +144     
==========================================
- Hits         4215     4209       -6     
- Misses       1761     1911     +150
Flag Coverage Δ
unit 68.77% <42.96%> (-1.76%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@svchb svchb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@svchb