Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Fix boundscheck for foreach_point_neighbor #95

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

efaulhaber
Copy link
Member

@efaulhaber efaulhaber commented Jan 16, 2025

This bug has two implications:

  1. Bounds are not checked correctly, which might cause unchecked out-of-bounds access.
  2. Bounds check fails when points is empty.

@efaulhaber efaulhaber added the bug Something isn't working label Jan 16, 2025
@efaulhaber efaulhaber requested review from svchb and LasNikas January 16, 2025 17:06
@efaulhaber efaulhaber self-assigned this Jan 16, 2025
@svchb svchb enabled auto-merge (squash) January 16, 2025 17:23
@svchb svchb merged commit 88925f9 into main Jan 16, 2025
10 checks passed
@svchb svchb deleted the ef/boundscheck-hotfix branch January 16, 2025 17:32
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.15%. Comparing base (16b5269) to head (e9d660b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/neighborhood_search.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   88.15%   88.15%           
=======================================
  Files          15       15           
  Lines         498      498           
=======================================
  Hits          439      439           
  Misses         59       59           
Flag Coverage Δ
unit 88.15% <66.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants