ShyLU: Don't access DualView's [h|d]_view directly #13786

masterleinad · 2025-02-05T20:04:07Z

@trilinos/shylu

Motivation

kokkos/kokkos#7716 proposes to deprecate the ability to access DualView's h_view and d_view members directly since modifying the allocations can get perturbed the DualView's internal status. This pull request replaces all places in ShyLU that use these members directly, in most places, verbatim with view_device resp. view_host.

Related Issues

Related to kokkos/kokkos#7716.

Signed-off-by: Daniel Arndt [email protected]

trilinos-autotester · 2025-02-05T20:44:43Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

masterleinad · 2025-02-13T17:03:36Z

@iyamazaki Would mind having a look?

iyamazaki

Thank you for the changes, @masterleinad !! I am not worried about it here since it is a unit-test, but I am curious if there are any performance impact (especially since the same view is accessed multiple times)?

masterleinad · 2025-02-13T19:45:04Z

Thank you for the changes, @masterleinad !! I am not worried about it here since it is a unit-test, but I am curious if there are any performance impact (especially since the same view is accessed multiple times)?

The same pull request proposes to return a const& when deprecated code is disabled so there shouldn't be change in behavior. Otherwise, the cost is that of a View copy.

cgcgcg · 2025-02-14T00:37:17Z

@masterleinad DCO

Signed-off-by: Daniel Arndt <[email protected]>

masterleinad · 2025-02-14T03:04:51Z

@masterleinad DCO

Fixed.

trilinos-autotester · 2025-02-14T03:22:13Z

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

trilinos-autotester · 2025-02-14T04:33:23Z

Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed.

trilinos-autotester · 2025-02-14T04:38:25Z

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

Build Num: 1115
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU;AT: AUTOMERGE
PULLREQUESTNUM	13786
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/masterleinad/Trilinos
TRILINOS_SOURCE_SHA	`97340cc`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2dcea06`

Build Information

Test Name: PR_gcc

Build Num: 1165
Status: STARTED

Jenkins Parameters

Parameter Name	Value
BLOCKING_BUILD	false
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU;AT: AUTOMERGE
PULLREQUESTNUM	13786
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/masterleinad/Trilinos
TRILINOS_SOURCE_SHA	`97340cc`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2dcea06`

Build Information

Test Name: PR_gcc-openmpi_debug

Build Num: 1166
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU;AT: AUTOMERGE
PULLREQUESTNUM	13786
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/masterleinad/Trilinos
TRILINOS_SOURCE_SHA	`97340cc`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2dcea06`

Build Information

Test Name: PR_clang

Build Num: 1164
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU;AT: AUTOMERGE
PULLREQUESTNUM	13786
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/masterleinad/Trilinos
TRILINOS_SOURCE_SHA	`97340cc`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2dcea06`

Build Information

Test Name: PR_cuda

Build Num: 1163
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU;AT: AUTOMERGE
PULLREQUESTNUM	13786
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8-gpu
TRILINOS_SOURCE_REPO	https://github.com/masterleinad/Trilinos
TRILINOS_SOURCE_SHA	`97340cc`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2dcea06`

Build Information

Test Name: PR_intel

Build Num: 1084
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU;AT: AUTOMERGE
PULLREQUESTNUM	13786
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/masterleinad/Trilinos
TRILINOS_SOURCE_SHA	`97340cc`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2dcea06`

Build Information

Test Name: PR_cuda-uvm

Build Num: 1163
Status: STARTED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU;AT: AUTOMERGE
PULLREQUESTNUM	13786
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/masterleinad/Trilinos
TRILINOS_SOURCE_SHA	`97340cc`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2dcea06`

Using Repos:

Repo: TRILINOS (masterleinad/Trilinos)

Pull Request Author: masterleinad

trilinos-autotester · 2025-02-14T05:29:17Z

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

Build Num: 1115
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU;AT: AUTOMERGE
PULLREQUESTNUM	13786
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/masterleinad/Trilinos
TRILINOS_SOURCE_SHA	`97340cc`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2dcea06`

Build Information

Test Name: PR_gcc

Build Num: 1165
Status: PASSED

Jenkins Parameters

Parameter Name	Value
BLOCKING_BUILD	false
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU;AT: AUTOMERGE
PULLREQUESTNUM	13786
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/masterleinad/Trilinos
TRILINOS_SOURCE_SHA	`97340cc`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2dcea06`

Build Information

Test Name: PR_gcc-openmpi_debug

Build Num: 1166
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-gnu-8.5.0-openmpi-4.1.6-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU;AT: AUTOMERGE
PULLREQUESTNUM	13786
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/masterleinad/Trilinos
TRILINOS_SOURCE_SHA	`97340cc`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2dcea06`

Build Information

Test Name: PR_clang

Build Num: 1164
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU;AT: AUTOMERGE
PULLREQUESTNUM	13786
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/masterleinad/Trilinos
TRILINOS_SOURCE_SHA	`97340cc`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2dcea06`

Build Information

Test Name: PR_cuda

Build Num: 1163
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU;AT: AUTOMERGE
PULLREQUESTNUM	13786
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8-gpu
TRILINOS_SOURCE_REPO	https://github.com/masterleinad/Trilinos
TRILINOS_SOURCE_SHA	`97340cc`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2dcea06`

Build Information

Test Name: PR_intel

Build Num: 1084
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU;AT: AUTOMERGE
PULLREQUESTNUM	13786
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/masterleinad/Trilinos
TRILINOS_SOURCE_SHA	`97340cc`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2dcea06`

Build Information

Test Name: PR_cuda-uvm

Build Num: 1163
Status: PASSED

Jenkins Parameters

Parameter Name	Value
FORCE_CLEAN	true
GENCONFIG_BUILD_NAME	rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS	pkg: ShyLU;AT: AUTOMERGE
PULLREQUESTNUM	13786
PULLREQUEST_CDASH_TRACK	Pull Request
TEST_REPO_ALIAS	TRILINOS
TRILINOS_NODE_LABEL	rhel8
TRILINOS_SOURCE_REPO	https://github.com/masterleinad/Trilinos
TRILINOS_SOURCE_SHA	`97340cc`
TRILINOS_SRN_CONFIG	true
TRILINOS_TARGET_BRANCH	develop
TRILINOS_TARGET_REPO	https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA	`2dcea06`

CDash Test Results for PR# 13786.

trilinos-autotester · 2025-02-14T05:29:35Z

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ iyamazaki ]!

trilinos-autotester · 2025-02-14T05:29:42Z

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

trilinos-autotester · 2025-02-14T05:29:55Z

Merge on Pull Request# 13786: IS A SUCCESS - Pull Request successfully merged

masterleinad requested a review from a team as a code owner February 5, 2025 20:04

iyamazaki approved these changes Feb 13, 2025

View reviewed changes

ShyLU: Don't access DualView's [h|d]_view directly

97340cc

Signed-off-by: Daniel Arndt <[email protected]>

masterleinad force-pushed the shylu_access_h_d_view branch from f0c8467 to 97340cc Compare February 14, 2025 03:04

cgcgcg added pkg: ShyLU AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed labels Feb 14, 2025

cgcgcg added the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Feb 14, 2025

trilinos-autotester removed the AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. label Feb 14, 2025

trilinos-autotester merged commit 51d04bb into trilinos:develop Feb 14, 2025
13 of 16 checks passed

trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Feb 14, 2025

ShyLU: Don't access DualView's [h|d]_view directly #13786

ShyLU: Don't access DualView's [h|d]_view directly #13786

Conversation

masterleinad commented Feb 5, 2025

Motivation

Related Issues

trilinos-autotester commented Feb 5, 2025

masterleinad commented Feb 13, 2025

iyamazaki left a comment

Choose a reason for hiding this comment

masterleinad commented Feb 13, 2025

cgcgcg commented Feb 14, 2025

masterleinad commented Feb 14, 2025

trilinos-autotester commented Feb 14, 2025

trilinos-autotester commented Feb 14, 2025

trilinos-autotester commented Feb 14, 2025

Build Information

Test Name: PR_gcc-openmpi-openmp

Jenkins Parameters

Build Information

Test Name: PR_gcc

Jenkins Parameters

Build Information

Test Name: PR_gcc-openmpi_debug

Jenkins Parameters

Build Information

Test Name: PR_clang

Jenkins Parameters

Build Information

Test Name: PR_cuda

Jenkins Parameters

Build Information

Test Name: PR_intel

Jenkins Parameters

Build Information

Test Name: PR_cuda-uvm

Jenkins Parameters

Using Repos:

trilinos-autotester commented Feb 14, 2025

Build Information

Test Name: PR_gcc-openmpi-openmp

Jenkins Parameters

Build Information

Test Name: PR_gcc

Jenkins Parameters

Build Information

Test Name: PR_gcc-openmpi_debug

Jenkins Parameters

Build Information

Test Name: PR_clang

Jenkins Parameters

Build Information

Test Name: PR_cuda

Jenkins Parameters

Build Information

Test Name: PR_intel

Jenkins Parameters

Build Information

Test Name: PR_cuda-uvm

Jenkins Parameters

trilinos-autotester commented Feb 14, 2025

trilinos-autotester commented Feb 14, 2025

trilinos-autotester commented Feb 14, 2025