Amesos2: compilation error w/ Tpetra deprecated code turned off #10247

ikalash · 2022-02-25T18:53:39Z

@trilinos/amesos2

We have failed Trilinos builds in the Albany and Albany-LCM builds with Tpetra deprecated code turned off due to Amesos2:

[ 78%] Building CXX object packages/amesos2/src/CMakeFiles/amesos2.dir/Amesos2_KokkosCrsMatrix_MatrixAdapter.cpp.o
[ 78%] Building CXX object packages/amesos2/src/CMakeFiles/amesos2.dir/Amesos2_TpetraMultiVecAdapter.cpp.o
[ 78%] Building CXX object packages/amesos2/src/CMakeFiles/amesos2.dir/Amesos2_KokkosMultiVecAdapter.cpp.o
[ 78%] Building CXX object packages/amesos2/src/CMakeFiles/amesos2.dir/Amesos2_Util.cpp.o
[ 78%] Building CXX object packages/amesos2/src/CMakeFiles/amesos2.dir/Amesos2_Version.cpp.o
[ 78%] Building CXX object packages/amesos2/src/CMakeFiles/amesos2.dir/Amesos2_KLU2.cpp.o
[ 78%] Building CXX object packages/amesos2/src/CMakeFiles/amesos2.dir/Amesos2_KLU2_TypeMap.cpp.o
In file included from [packages/amesos2/src/Amesos2_KLU2.cpp:48](https://blob/master/packages/amesos2/src/Amesos2_KLU2.cpp#L48):
In file included from [packages/amesos2/src/Amesos2_KLU2_def.hpp:59](https://blob/master/packages/amesos2/src/Amesos2_KLU2_def.hpp#L59):
In file included from [packages/amesos2/src/Amesos2_SolverCore_def.hpp:56](https://blob/master/packages/amesos2/src/Amesos2_SolverCore_def.hpp#L56):
[packages/amesos2/src/Amesos2_MatrixAdapter_def.hpp:512](https://blob/master/packages/amesos2/src/Amesos2_MatrixAdapter_def.hpp#L512):61: error: no member named 'getNodeE

https://sems-cdash-son.sandia.gov/cdash/viewBuildError.php?buildid=29958
https://sems-cdash-son.sandia.gov/cdash/viewBuildError.php?buildid=29945

Could someone please have a look? Tagging @lxmota who will also be interested in this issue.

The text was updated successfully, but these errors were encountered:

cgcgcg · 2022-02-25T20:45:20Z

@trilinos/framework Do we have a nightly build that disables deprecated code? This is the third time this stuff is hitting Albany in the last week or so.

ZUUL42 · 2022-02-25T21:08:47Z

@cgcgcg, I'm not sure if it's useful for you in it's current state, but we do have this deprecated nightly build: CDash

cgcgcg · 2022-02-25T21:10:31Z

@ZUUL42 Thank you! Any idea why that build displays in such a weird way? Makes parsing what's actually failing quite difficult.

ZUUL42 · 2022-02-25T21:29:06Z

@cgcgcg, sorry, I have not had the chance to look into that.

ndellingwood · 2022-02-25T21:41:22Z

Looks like the changes to replace getNode* by getLocal* in #10189 need to be made to Amesos2. I'll put in a PR shortly

Attempts to address issue trilinos#10247 Related to trilinos#10189

ndellingwood · 2022-02-25T21:51:08Z

Opened PR #10250, hopefully just the name change update is needed

ikalash · 2022-03-01T17:23:02Z

Now there are issues with MueLu: https://sems-cdash-son.sandia.gov/cdash/viewBuildError.php?buildid=30080

[Trilinos/packages/muelu/src/Utils/MueLu_Utilities_kokkos_def.hpp:282](https://blob/master/Trilinos/packages/muelu/src/Utils/MueLu_Utilities_kokkos_def.hpp#L282):32: error: ‘class Tpetra::CrsMatrix<double, int, long long int, Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Serial> >’ has no member named ‘getNodeMaxNumRowEntries’; did you mean ‘getLocalMaxNumRowEntries’?

This is turning into a game of wack-a-mole...!

cgcgcg · 2022-03-01T17:27:12Z

@ikalash What's the SHA for that build? I did push some deprecated changes yesterday: #10256 and #10257.

EDIT: Looks like the build had #10256, but not #10257.

ikalash · 2022-03-01T17:32:31Z

Here it is:

commit 1760977a3e33da0dc7310f1e815c2e88fd51ebde
Merge: 6e5d996 1e1bd8a
Author: trilinos-autotester <[email protected]>
Date:   Mon Feb 28 14:18:04 2022 -0700

    Merge Pull Request #10256 from cgcgcg/Trilinos/mueluFixes
    
    Automatically Merged using Trilinos Pull Request AutoTester
    PR Title: Deprecation fixes
    PR Author: cgcgcg

cgcgcg · 2022-03-01T17:34:10Z

Ok. Hopefully you won't be seeing the MueLu issues anymore tomorrow. There are PRs #10261 and #10262 for the next set of packages.

ikalash · 2022-03-01T20:50:21Z

Thanks @cgcgcg , I will keep my eye out for the fixes.

ikalash · 2022-03-01T21:15:23Z

Could someone help me answer the following questions? It's for a code I support that uses Trilinos:

is Tpetra::StaticProfile going away with the deprecation? I'm seeing errors that look as following:

/home/ikalash/Trilinos/DataTransferKit/packages/Operators/test/tstPolynomialMatrix.cpp:111:54: error: ‘StaticProfile’ is not a member of ‘Tpetra’
                 row_map, col_map, poly_size, Tpetra::StaticProfile ) );
                                                      ^~~~~~~~~~~~~

It looks like getLocalRowView changed too - does it take a Kokkos::View now?

/home/ikalash/Trilinos/DataTransferKit/packages/Operators/test/tstCrsMatrixFill.cpp:173:54: error: no matching function for call to ‘Tpetra::CrsMatrix<double, int, long long int>::getLocalRowView(int, Teuchos::ArrayView<const int>&, Teuchos::ArrayView<const double>&)’
     A->getLocalRowView( 0, indices_view, values_view );

cgcgcg · 2022-03-01T21:20:30Z

I believe StaticProfile was already the only option before, I think all you need to do is remove Tpetra::StaticProfile from the call.

Trilinos/packages/tpetra/core/src/Tpetra_CrsMatrix_decl.hpp

Lines 576 to 585 in 539a887

    
           #ifdef TPETRA_ENABLE_DEPRECATED_CODE 
        
               TPETRA_DEPRECATED 
        
               CrsMatrix (const Teuchos::RCP<const map_type>& rowMap, 
        
                          const size_t maxNumEntriesPerRow, 
        
                          const ProfileType pftype, 
        
                          const Teuchos::RCP<Teuchos::ParameterList>& params = Teuchos::null); 
        
           #endif 
        
               CrsMatrix (const Teuchos::RCP<const map_type>& rowMap, 
        
                          const size_t maxNumEntriesPerRow, 
        
                          const Teuchos::RCP<Teuchos::ParameterList>& params = Teuchos::null);

Yes, it's Kokkos views now, see:

Trilinos/packages/tpetra/core/src/Tpetra_CrsMatrix_decl.hpp

Lines 2742 to 2753 in 539a887

    
           #ifdef TPETRA_ENABLE_DEPRECATED_CODE 
        
               TPETRA_DEPRECATED 
        
               void 
        
               getLocalRowView (LocalOrdinal LocalRow, 
        
                                Teuchos::ArrayView<const LocalOrdinal>& indices, 
        
                                Teuchos::ArrayView<const Scalar>& values) const override; 
        
           #endif  // TPETRA_ENABLE_DEPRECATED_CODE 
        
               void 
        
               getLocalRowView(LocalOrdinal LocalRow, 
        
                               local_inds_host_view_type &indices, 
        
                               values_host_view_type &values) const override;

ikalash · 2022-03-01T21:21:29Z

Thanks @cgcgcg let me see if I can fix this. Thanks for your responsiveness - I haven't been following all the changes to Tpetra and your replies will save me a lot of time grepping through the code to try to figure out what changed!

mperego · 2022-03-02T00:15:44Z

@ikalash I also fixed a few calls to deprecated code in Zoltan2 (PR #10264) that were needed to build Albany. Not sure you use Zoltan2 in Albany-LCM. I also had to disable Galeri (which we do not use anyway). Other changes to Albany were trivial (sandialabs/Albany#797).

ikalash · 2022-03-02T00:27:59Z

Thanks @mperego ! I had to make a few changes in LCM today (as well as DTK) but things seem clean now. I really hope the dashboard has no failures tomorrow for LCM at least!

brian-kelley · 2022-03-14T23:19:03Z

@ikalash Did switching to the non-deprecated functions fix Albany?

ikalash · 2022-03-15T06:10:34Z

Yes, I think so. This issue can be closed.

ikalash added type: bug The primary issue is a bug in Trilinos code or tests pkg: Amesos2 client: Albany Issue impacting the Albany project client: LCM Solid mechanics fork of Albany labels Feb 25, 2022

ndellingwood added a commit to ndellingwood/Trilinos that referenced this issue Feb 25, 2022

Amesos2: update Tpetra getNode* names to getLocal*

fedb22f

Attempts to address issue trilinos#10247 Related to trilinos#10189

ndellingwood mentioned this issue Feb 25, 2022

Amesos2: update Tpetra getNode* names to getLocal* #10250

Merged

mperego closed this as completed Mar 15, 2022

jhux2 added this to Tpetra Aug 12, 2024

jhux2 moved this to Done in Tpetra Aug 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Amesos2: compilation error w/ Tpetra deprecated code turned off #10247

Amesos2: compilation error w/ Tpetra deprecated code turned off #10247

ikalash commented Feb 25, 2022

cgcgcg commented Feb 25, 2022

ZUUL42 commented Feb 25, 2022

cgcgcg commented Feb 25, 2022

ZUUL42 commented Feb 25, 2022

ndellingwood commented Feb 25, 2022

ndellingwood commented Feb 25, 2022

ikalash commented Mar 1, 2022

cgcgcg commented Mar 1, 2022 •

edited

Loading

ikalash commented Mar 1, 2022

cgcgcg commented Mar 1, 2022

ikalash commented Mar 1, 2022

ikalash commented Mar 1, 2022

cgcgcg commented Mar 1, 2022 •

edited

Loading

ikalash commented Mar 1, 2022

mperego commented Mar 2, 2022 •

edited

Loading

ikalash commented Mar 2, 2022

brian-kelley commented Mar 14, 2022

ikalash commented Mar 15, 2022

Amesos2: compilation error w/ Tpetra deprecated code turned off #10247

Amesos2: compilation error w/ Tpetra deprecated code turned off #10247

Comments

ikalash commented Feb 25, 2022

cgcgcg commented Feb 25, 2022

ZUUL42 commented Feb 25, 2022

cgcgcg commented Feb 25, 2022

ZUUL42 commented Feb 25, 2022

ndellingwood commented Feb 25, 2022

ndellingwood commented Feb 25, 2022

ikalash commented Mar 1, 2022

cgcgcg commented Mar 1, 2022 • edited Loading

ikalash commented Mar 1, 2022

cgcgcg commented Mar 1, 2022

ikalash commented Mar 1, 2022

ikalash commented Mar 1, 2022

cgcgcg commented Mar 1, 2022 • edited Loading

ikalash commented Mar 1, 2022

mperego commented Mar 2, 2022 • edited Loading

ikalash commented Mar 2, 2022

brian-kelley commented Mar 14, 2022

ikalash commented Mar 15, 2022

cgcgcg commented Mar 1, 2022 •

edited

Loading

cgcgcg commented Mar 1, 2022 •

edited

Loading

mperego commented Mar 2, 2022 •

edited

Loading