Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New resume_following_ctrl_c test fails sporadically #949

Closed
smoelius opened this issue Jan 11, 2024 · 1 comment
Closed

New resume_following_ctrl_c test fails sporadically #949

smoelius opened this issue Jan 11, 2024 · 1 comment

Comments

@smoelius
Copy link
Collaborator

https://github.com/trailofbits/necessist/actions/runs/7491845342/job/20394001969#step:9:443

I think maybe we should wait for this line to be written to the console before sending SIGINT:

examples/basic/src/lib.rs:4:5-4:12: `n += 1;` passed

Here is some related code from test-fuzz we might borrow from: https://github.com/trailofbits/test-fuzz/blob/5a8b0595d21d3260e5c7e2a7fd2a1b2a05f0be55/cargo-test-fuzz/src/lib.rs#L440-L462
smoelius added a commit to smoelius/necessist that referenced this issue Jan 15, 2024
@smoelius
Fix trailofbits#949
027c47b
smoelius added a commit to smoelius/necessist that referenced this issue Jan 16, 2024
@smoelius
Fix trailofbits#949
2566c1f
github-merge-queue bot pushed a commit that referenced this issue Jan 16, 2024
@smoelius
Fix #949
3e60f03
@smoelius
Copy link
Collaborator Author

This should be fixed by #957.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smoelius