Need a way to verify that register_lints registers all workspace members

[smoelius]

E.g., that this register_lints function registers all the supplementary workspace members:

dylint/examples/supplementary/src/lib.rs

Lines 11 to 20 in 5cb7877

	pub fn register_lints(sess: &rustc_session::Session, lint_store: &mut rustc_lint::LintStore) {
	// smoelius: Please keep the following `register_lints` calls sorted by crate name.
	commented_code::register_lints(sess, lint_store);
	escaping_doc_link::register_lints(sess, lint_store);
	inconsistent_struct_pattern::register_lints(sess, lint_store);
	redundant_reference::register_lints(sess, lint_store);
	unnamed_constant::register_lints(sess, lint_store);
	unnecessary_borrow_mut::register_lints(sess, lint_store);
	unnecessary_conversion_for_trait::register_lints(sess, lint_store);
	}

At the moment, I'm not sure how best to do this.

[augustin-v]

I'd love to work on this! I'm guessing this is a function that would go to cargo-dylint/tests/ci.rs ?

[smoelius]

Yeah.

Do you have thoughts on how you would implement this?

The best idea I have come up with is:

• Find each example library workspace (examples::iter might help with that).
• Then, for each:
  • Extract the register_lints calls from the root package's src/lib.rs file using regular expressions.
  • Get the workspace's packages using cargo metadata.
  • Compare the extracted register_lints calls to the list of found packages.

I'm open to other ideas though.

Please be aware that something in Dylint broke with the upgrade to Rust 1.85. I need to investigate.

[augustin-v]

That sounds very good and this made me realize that I forgot to add the nonexistent_path_in_comment to the lib.rs file.

• Find each example library workspace (examples::iter might help with that).

This seems perfect for the task indeed, I was thinking about how we could fetch the examples with multiple workspaces before looking at it, and that does just that.

Definitely doable! Could I work on it?

[smoelius]

Definitely doable! Could I work on it?

Yes! Please!