Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with Inventory Profiles Next's locked slots functionality #198

Open
1 of 6 tasks
heldheld opened this issue Mar 22, 2024 · 8 comments
Open
1 of 6 tasks

Conflict with Inventory Profiles Next's locked slots functionality #198

heldheld opened this issue Mar 22, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@heldheld
Copy link

heldheld commented Mar 22, 2024

Version information

itemswapper-fabric-0.5.5-mc1.20.4

Other relevant installed mods

Inventory Profiles Next 1.10.9

Expected Behavior

When a slot has been locked using the Locked Slot functionality of the mod Inventory Profiles Next, I expect Item Swapper to realise this and not be able to be used to swap items from/to that slot.

Actual Behavior

The locked slots are treated as any other slot.

Reproduction Steps

Lock a slot, that holds an item, in the hotbar. Select that slot and use either of Item Swappers hotkeys to swap the item to another.

Render engine

  • Vanilla
  • Sodium(optionally with Iris)
  • Optifine
  • VulkanMod
  • Canvas
  • Other

Additional information

No response

@heldheld heldheld added the bug Something isn't working label Mar 22, 2024
@tr7zw
Copy link
Owner

tr7zw commented Mar 25, 2024

I expect Item Swapper to realise this and not be able to be used to swap items from/to that slot.

Since there is no "locked slot" logic in vanilla Minecraft, there is nothing for the mod to realize/check for this. This is not really a bug, more a compatibility request. Will look into it at some later point.

@heldheld
Copy link
Author

This is not really a bug, more a compatibility request.

Ah yes, I see what you mean, my mistake.

Will look into it at some later point.

Good luck, hope you can find a way, thanks for wanting to look into it.

@blackd
Copy link

blackd commented Mar 25, 2024

IPN has an API that returns the locked slots.

https://github.com/blackd/Inventory-Profiles/blob/all-in-one/shared-sources%2Fsrc%2Fmain%2Fkotlin%2Forg%2Fanti_ad%2Fmc%2Fipn%2Fapi%2Faccess%2FIPN.kt

In java it will be something like this

IPN.getInstance().getLockedSlots()

@tr7zw tr7zw added enhancement New feature or request and removed bug Something isn't working labels Apr 23, 2024
@tr7zw tr7zw changed the title [BUG] Conflict with Inventory Profiles Next's locked slots functionality Conflict with Inventory Profiles Next's locked slots functionality Apr 23, 2024
@heldheld
Copy link
Author

heldheld commented Nov 1, 2024

Was wondering if there is any update on this request?

@tr7zw
Copy link
Owner

tr7zw commented Nov 1, 2024

No, not really.

@heldheld
Copy link
Author

heldheld commented Nov 1, 2024

No, not really.

Okay, well just to let you know, I am still interested in this as I still use both mods actively. Not trying to rush you though.

@tr7zw
Copy link
Owner

tr7zw commented Nov 1, 2024

grafik
The limiting factor is time. Guess when I was done with uni and started a fulltime job 😅 .

@blackd
Copy link

blackd commented Nov 1, 2024

no one tells... ignorance is bliss :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants