-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests to use tasty + nettest interface + batching #148
Comments
I highly do not recommend starting using batches before one issue about batching is implemented. The interface should change, hopefully, after that making a batch will be as simple as wrapping a code into |
I'll add this as a note here: there is a TODO in The issue has however since been closed in favor of adding it only to nettest, so as per the number 4 of this issue we should either remove that while migrating those tests to |
Note, for future reference: this is in large part solved by #187 It's possible however that there are some improvements left (particularly batching) so we'l need to check that. |
There really isn't much potential for batching, except for the initial set-up/origination (and even there it's somewhat limited) In most cases, as things are stateful, either next operations depend on the result of the previous ones, operations from different senders need to be interleaved, or we're testing for errors in specific calls, neither of which allows for effective batching. |
Problem: a lot of initial setup in tests can be batched, considerably speeding up network tests. Solution: do that. This replaces individual address setup with a structure in some tests. This is a little bit wasteful, but barely so, as addresses should be reused.
Problem: a lot of initial setup in tests can be batched, considerably speeding up network tests. Solution: do that. This replaces individual address setup with a structure in some tests. This is a little bit wasteful, but barely so, as addresses should be reused.
Clarification and motivation
Our tests are somewhat messy and slow, we can clean them up to use latest
cleveland
features more efficiently.Acceptance criteria
hspec
andtasty-hspec
to group tests, we group them usingtasty
directly.stablecoin-nettest
andstablecoin-test
are merged into one test-suite. Previously we kept them separated to be able to run only non-network tests, but now it's possible in a united test suite as well.The text was updated successfully, but these errors were encountered: