Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pseuodocode review #1

Open
adler-sudo opened this issue Jul 31, 2021 · 0 comments
Open

Pseuodocode review #1

adler-sudo opened this issue Jul 31, 2021 · 0 comments

Comments

@adler-sudo
Copy link

adler-sudo commented Jul 31, 2021

Great work Mr. Persse!

Generating a dictionary at the beginning that stores expected combinations of indexes may be useful in determining where to send records based on results.

What will your method be for getting records to new fastq files? I have seen a couple options: open all output files, generate dictionary, or append as you go. Not sure what the best practice is going to be here but may be good to think about CPU and memory usage.

In the last piece regarding the handling of indexes with N, are you looking thinking about potentially doing your best to estimate the missing value? I think this may be above and beyond. My understanding is we just send this to the low-qual/missing index file. Though maybe you'll get bonus points for posing a potential alternative. Just be sure not to write the estimated index to your 'matched index' file.

Functions all look great!

Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant