Make sync prefer system python instead of uv managed #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do not want to hardcode this. I want user to be able to change it, so at the very least should be configurable. |
|
Doable, no problem. Still, I think that we need to alter the default to ensure the uv will prefer system instead of managed (unless configured). Otherwise, users will face broken like the bug this change is supposed to fix. |
|
Last failure is related to iarna/iarna-toml#48 and astral-sh/setup-uv#242 - i will make a patch to stick to older versions with setup-uv for now. Now I am happy that I never used that action myself, did the install manually. #153 is fixing the CI |
gaborbernat
approved these changes
Jan 16, 2025
gaborbernat
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #110
Depends-On: #153