Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part of problem tests missing for the 'Add Functionality to Existing Global Interfaces' problem #11

Open
boltex opened this issue Nov 23, 2023 · 0 comments

Comments

@boltex
Copy link

boltex commented Nov 23, 2023

This last part is missing from the problem's tests at the bottom. (It's visible in the solutions video and in the problem's description on the side.

it("Should not be available on globalThis", () => {
  expect(
    // @ts-expect-error
    globalThis.makeGreeting,
  ).toBe(undefined);
});

Edit:
After adding this part and trying it out, I see it's not totally appropriate - perhaps typescript has changed its behavior in the past few updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant