Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update POI Dependencies #26

Open
smahood opened this issue Feb 2, 2016 · 3 comments
Open

Update POI Dependencies #26

smahood opened this issue Feb 2, 2016 · 3 comments
Milestone

Comments

@smahood
Copy link
Contributor

smahood commented Feb 2, 2016

This is more for discussion than anything, but is there any interest in updating POI to the latest version if I test and submit a PR? Current version is a couple years old at this point.

@tomfaulhaber
Copy link
Owner

Sorry, @smahood, this got lost in my onslaught of email and I didn't see it.

Sure, that sounds great to me.

Are there any particular things that we want from the latest version or are you just thinking about keeping up to date?

@smahood
Copy link
Contributor Author

smahood commented Feb 16, 2016

Mainly wanting to keep things up to date. I tried just plugging in the new versions and it didn't work, so I'm planning on stepping through each release and seeing if there's anything really interesting that would be worth looking at adding and will open an issue for the ones I find.

@tomfaulhaber tomfaulhaber added this to the 0.3.3 milestone Mar 20, 2016
@tomfaulhaber
Copy link
Owner

One thing we need to do once we've updated is use the .getDrawingPatriarch method in place of the .createDrawingPatriarch method when we don't want to create new drawings. This will eliminate issues like #13 and just keep things generally cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants