Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rustix instead of libc #1735

Closed
notgull opened this issue Dec 7, 2023 · 2 comments
Closed

Use rustix instead of libc #1735

notgull opened this issue Dec 7, 2023 · 2 comments

Comments

@notgull
Copy link

notgull commented Dec 7, 2023

rustix is a system call wrapper that wraps raw system calls on Linux and libc on other platforms. It would allow mio to refactor out error handling and unsafe syscall handling code from its codebase. More materialistically, rustix bypasses libc for Linux system calls. In some cases, this can allow system calls to be directly inlined into their calling functions, saving instructions and increasing execution speed.

Its MSRV is 1.63, but as the MSRV was just bumped to 1.74 this shouldn't be an issue.

Rel: #1588

@Darksonn
Copy link
Contributor

Darksonn commented Dec 7, 2023

This doesn't seem necessary to me. We generally try pretty hard to not add new dependencies to Tokio, especially ones that are not under the Tokio org.

@Thomasdezeeuw
Copy link
Collaborator

I'm not interested in adding dependencies at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants