Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[The Old Prince 1871] Incorrect revenue running the PIER with 3 shares #11525

Open
Talbatross opened this issue Feb 9, 2025 · 0 comments · May be fixed by #11531
Open

[The Old Prince 1871] Incorrect revenue running the PIER with 3 shares #11525

Talbatross opened this issue Feb 9, 2025 · 0 comments · May be fixed by #11531
Labels
1871 bug Prevents game from being played correctly

Comments

@Talbatross
Copy link
Contributor

What's your Game ID?
https://18xx.games/game/196973

How to Reproduce the Bug?
I owned all shares of the PIER (there was 3 left). I ran for 300 and it only paid me 99 a share. From the rules, it states "If the PEIR pays dividends, divide the total earnings by the number of shares of PEIR in player hands. Each player receives that amount rounded up per share."

Image

Which Browser / Platform?
Brave: 1.75.175 Chromium: 133.0.6943.54 (Official Build) (64-bit)
@ollybh ollybh added bug Prevents game from being played correctly 1871 and removed needs triage labels Feb 9, 2025
ollybh added a commit to ollybh/18xx that referenced this issue Feb 9, 2025
@ollybh
[1871] Fix dividend payout when there are three PEIR shares
4808d23 
`entity.total_shares`` doesn't always work correctly for PEIR.  If there
are three shares then each is a 33% share, and `total_shares` returns
3.030303...

This can lead to rounding errors in dividend payout, with a revenue of
300 being calculated as 99 per share.

Fixes tobymao#11525.
ollybh added a commit to ollybh/18xx that referenced this issue Feb 9, 2025
@ollybh
[1871] Fix dividend payout when there are three PEIR shares
94964d9 
`entity.total_shares`` doesn't always work correctly for PEIR.  If there
are three shares then each is a 33% share, and `total_shares` returns
3.030303...

This can lead to rounding errors in dividend payout, with a revenue of
300 being calculated as 99 per share.

Fixes tobymao#11525.
@ollybh ollybh linked a pull request Feb 9, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1871 bug Prevents game from being played correctly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[1871] Fix dividend payout when there are three PEIR shares ollybh/18xx
2 participants
@Talbatross @ollybh