Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1837] UG3 wasn't exchanged when 5T bought #11482

Closed
ianwilson156 opened this issue Jan 27, 2025 · 4 comments · Fixed by #11498
Closed

[1837] UG3 wasn't exchanged when 5T bought #11482

ianwilson156 opened this issue Jan 27, 2025 · 4 comments · Fixed by #11498
Assignees
Labels
1837 bug Prevents game from being played correctly

Comments

@ianwilson156
Copy link

(Hotseat game)
The director of the U3 chose to keep it out of the UG when it formed. When the first 5T was bought, UG3 closed, but the UG3 shares were not swapped for UG shares (the two reserved shares remained but couldn't be purchased).
The rules say: "With the sale of the first 5 train: any unconverted minor companies of the Hungarian National must convert at this time."

@ollybh ollybh added bug Prevents game from being played correctly 1837 and removed needs triage labels Jan 27, 2025
@crericha
Copy link
Collaborator

@ianwilson156 do you still have the hotseat game data for this one? It'll be easier to fix if I have a reproducible example. Thanks!

@ianwilson156
Copy link
Author

I can't get back into the game now you've fixed the other issues!
I'll try another hotseat game and see if I can recreate the problem...

@ianwilson156
Copy link
Author

In my latest hotseat:

ianwilson156/hs_qojosvwm_1738145709 (2).json

The problem seems to be that the 'other half' of UG1 and UG3 aren't being swapped for the associated reserved share, either when UG forms (UG1) or when UG3 is forced in (at the 5-train).

@crericha
Copy link
Collaborator

Okay, that makes sense. An oversight on my end.

@crericha crericha linked a pull request Jan 30, 2025 that will close this issue
@crericha crericha self-assigned this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1837 bug Prevents game from being played correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants