Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18RoyalGorge]: Total/Delta values in the spreadsheet do not include dividends from CF&I and VGC #11371

Open
GMaciag opened this issue Nov 20, 2024 · 1 comment
Labels
18RoyalGorge minor bug A minor bug that doesn't impact game play (erronous logging) spreadsheet Issues relating to spreadsheet

Comments

@GMaciag
Copy link

GMaciag commented Nov 20, 2024

https://18xx.games/game/186098?action=103

At the end of the first round of OR's CF&I and VGC paid out dividends to the players - 66$ in my case. Yet, the delta value in the spreadsheet for OR 1.2 is only 5$ (coming from my private). The money from CF&I and VGC is also not included in the total value in that part of the spreadsheet. The Cash/Value/Liquidity values above are correct.

I understand this is a minor issue, but would be great if you could fix it when you have the time. Thank you!

@GMaciag GMaciag changed the title 18RoyalGorge: Total/Delta values in the spreadsheet do not include dividends from CF&I and VGC [18RoyalGorge]: Total/Delta values in the spreadsheet do not include dividends from CF&I and VGC Nov 20, 2024
@ollybh ollybh added minor bug A minor bug that doesn't impact game play (erronous logging) spreadsheet Issues relating to spreadsheet 18RoyalGorge and removed needs triage labels Nov 23, 2024
@michaeljb
Copy link
Collaborator

This is due to the timing of these methods:

  • Game::Base#store_player_info
  • Game::Base#transition_to_next_round!
  • G18RoyalGorge ::Game#next_round!
  • G18RoyalGorge ::Game#or_set_finished (this is where the payouts for those companies currently happens)

Maybe G18RoyalGorge::Game could override transition_to_next_round! and check if we're at the end of the OR set, and then do the payouts before calling super.

Going to focus on higher priority issues for now.

@michaeljb michaeljb removed their assignment Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
18RoyalGorge minor bug A minor bug that doesn't impact game play (erronous logging) spreadsheet Issues relating to spreadsheet
Projects
None yet
Development

No branches or pull requests

3 participants