Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow key input for ChordAnalyser #34

Open
titus-ong opened this issue Jul 26, 2020 · 1 comment
Open

Allow key input for ChordAnalyser #34

titus-ong opened this issue Jul 26, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@titus-ong
Copy link
Owner

Currently, ChordAnalyser only accepts scales for its input, which is inconsistent with ChordRomanConverter which can accept keys. Allow ChordAnalyser to accepts keys as well in its analysing methods.
@titus-ong titus-ong added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jul 26, 2020
@titus-ong titus-ong removed good first issue Good for newcomers help wanted Extra attention is needed labels Aug 31, 2020
@titus-ong
Copy link
Owner Author

Will be included in #39. By default, the analyser should only accept keys rather than scales since that makes more sense musically (analyse a chord against the key signature, rather than against a scale).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@titus-ong