Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WeConnect fails due to not using Https with OAuth2 #381

Open
RaimondB opened this issue Dec 31, 2024 · 8 comments
Open

WeConnect fails due to not using Https with OAuth2 #381

RaimondB opened this issue Dec 31, 2024 · 8 comments

Comments

@RaimondB
Copy link

I am getting this error in the logs

weconnect-mqtt-1 | File "/usr/local/lib/python3.12/site-packages/weconnect/auth/openid_session.py", line 194, in request weconnect-mqtt-1 | url, headers, data = self.addToken(url, body=data, headers=headers, access_type=access_type, token=token) weconnect-mqtt-1 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ weconnect-mqtt-1 | File "/usr/local/lib/python3.12/site-packages/weconnect/auth/openid_session.py", line 238, in addToken weconnect-mqtt-1 | self.login() weconnect-mqtt-1 | File "/usr/local/lib/python3.12/site-packages/weconnect/auth/we_connect_session.py", line 76, in login weconnect-mqtt-1 | response = self.doWebAuth(authorizationUrl) weconnect-mqtt-1 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ weconnect-mqtt-1 | File "/usr/local/lib/python3.12/site-packages/weconnect/auth/we_connect_session.py", line 253, in doWebAuth weconnect-mqtt-1 | afterLoginResponse = self.get(afterLoginUrl, allow_redirects=False, access_type=AccessType.NONE) weconnect-mqtt-1 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ weconnect-mqtt-1 | File "/usr/local/lib/python3.12/site-packages/requests/sessions.py", line 602, in get weconnect-mqtt-1 | return self.request("GET", url, **kwargs) weconnect-mqtt-1 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ weconnect-mqtt-1 | File "/usr/local/lib/python3.12/site-packages/weconnect/auth/we_connect_session.py", line 69, in request weconnect-mqtt-1 | return super(WeConnectSession, self).request( weconnect-mqtt-1 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ weconnect-mqtt-1 | File "/usr/local/lib/python3.12/site-packages/weconnect/auth/openid_session.py", line 188, in request weconnect-mqtt-1 | raise InsecureTransportError() weconnect-mqtt-1 | oauthlib.oauth2.rfc6749.errors.InsecureTransportError: (insecure_transport) OAuth 2 MUST utilize https.

@luke-ff
Copy link

luke-ff commented Jan 23, 2025

Same here (using docker):
Traceback (most recent call last): File "/usr/local/bin/weconnect-mqtt", line 8, in <module> sys.exit(main()) ^^^^^^ File "/usr/local/lib/python3.12/site-packages/weconnect_mqtt/weconnect_mqtt_base.py", line 343, in main mqttCLient.run() File "/usr/local/lib/python3.12/site-packages/weconnect_mqtt/weconnect_mqtt_base.py", line 782, in run self.updateWeConnect() File "/usr/local/lib/python3.12/site-packages/weconnect_mqtt/weconnect_mqtt_base.py", line 462, in updateWeConnect self.weConnect.update(updateCapabilities=self.updateCapabilities, updatePictures=self.updatePictures, selective=self.selective, force=True) File "/usr/local/lib/python3.12/site-packages/weconnect/weconnect.py", line 194, in update self.updateVehicles(updateCapabilities=updateCapabilities, updatePictures=updatePictures, force=force, selective=selective) File "/usr/local/lib/python3.12/site-packages/weconnect/weconnect.py", line 205, in updateVehicles data = self.fetchData(url, force) ^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/weconnect/weconnect.py", line 373, in fetchData statusResponse: requests.Response = self.session.get(url, allow_redirects=False) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/requests/sessions.py", line 602, in get return self.request("GET", url, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/weconnect/auth/we_connect_session.py", line 69, in request return super(WeConnectSession, self).request( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/weconnect/auth/openid_session.py", line 194, in request url, headers, data = self.addToken(url, body=data, headers=headers, access_type=access_type, token=token) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/weconnect/auth/openid_session.py", line 238, in addToken self.login() File "/usr/local/lib/python3.12/site-packages/weconnect/auth/we_connect_session.py", line 76, in login response = self.doWebAuth(authorizationUrl) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/weconnect/auth/we_connect_session.py", line 253, in doWebAuth afterLoginResponse = self.get(afterLoginUrl, allow_redirects=False, access_type=AccessType.NONE) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/requests/sessions.py", line 602, in get return self.request("GET", url, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/weconnect/auth/we_connect_session.py", line 69, in request return super(WeConnectSession, self).request( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/weconnect/auth/openid_session.py", line 188, in request raise InsecureTransportError() oauthlib.oauth2.rfc6749.errors.InsecureTransportError: (insecure_transport) OAuth 2 MUST utilize https.

@tillsteinbach
Copy link
Owner

Are you on the latest version? This is a problem with accepting the terms and conditions.

@luke-ff
Copy link

luke-ff commented Jan 26, 2025 via email

@tillsteinbach
Copy link
Owner

no, latest version of WeConnect-mqtt

@luke-ff
Copy link

luke-ff commented Jan 26, 2025 via email

@RaimondB
Copy link
Author

RaimondB commented Jan 26, 2025

I found out in one of the other issues of this repo that you need to change your country to Germany and language to German in you Volkswagen id. Then you don't see the screen to accept the terms anymore after accepting once.

This does not impact the app or other websites.

Also you need to login to the vw id app once so that the app is authorised. I have a passat gte to uses the Volkswagen app. But I got access denied until I once logged into the vw id app. Even though it does give an error during login.

See also #377

@tillsteinbach
Copy link
Owner

Huh, you still have the Volkswagen ID app? I worked with the now called „Volkswagen“ app with my Passat for more than a year. I think there is only one app for all cars.

@luke-ff
Copy link

luke-ff commented Jan 26, 2025

I don't know why, but now WeConnect-mqtt works for me. Maybe it's the TC-Parameter (was Europe/Vienna, now set to Europe/Berlin) or the "-v"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants