setup public config for zos light #3
Conversation
Omarabdul3ziz
commented
Jan 28, 2025
Omarabdul3ziz
commented
- add set/unset methods to the light networker
- change reading domain configuration from kernel param to the persistence file
- expose the function to zbus from netlightd service to other services
- zos4: support rpc call to set the gateway domain zos#2525
- add set/unset methods to the light networker - change reading domain configuration from kernel param to the persistance file
expose the function to zbus from netlightd service to other services like noded/gateway to read the domain
| netStub := stubs.NewNetworkerLightStub(g.cl) | ||
| config, err := netStub.LoadPublicConfig(context.Background()) | ||
| baseDomain := config.Domain | ||
| if baseDomain == "" || err == nil { |
There was a problem hiding this comment.
this is a bit confusing
u r calling config.domain without checking the error returned from loadPublicConfig the method returns nil in case of error which will result in an error when calling config.domain
so plz check the error first then u can call config.Domain
this line
if baseDomain == "" || err == nil {
should be
if baseDomain == "" || err != nil {
There was a problem hiding this comment.
yes, this is wrong, it was a wip comment fixed in zoslight repo but didn't do the commit here https://github.com/threefoldtech/zoslight/blob/ff8a7a63a0c9c717a3e2ceed73112e8fbf99da83/pkg/gateway/gateway.go#L348
in case an err, config.Domain will be empty anyway. but you are right cleaner to check for the error first
| if !found { | ||
| netStub := stubs.NewNetworkerLightStub(g.cl) | ||
| config, err := netStub.LoadPublicConfig(context.Background()) | ||
| domain := config.Domain |
There was a problem hiding this comment.
same as the above comment
| netStub := stubs.NewNetworkerLightStub(n.cl) | ||
| config, err := netStub.LoadPublicConfig(context.Background()) | ||
|
|
||
| if config.Domain != "" && err == nil { |
There was a problem hiding this comment.
same as first comment
| return nil | ||
| } | ||
|
|
||
| func (n *networker) LoadPublicConfig() (pkg.PublicConfig, error) { |
There was a problem hiding this comment.
no need for this method u already calling public.loadPublicConfig without changes
There was a problem hiding this comment.
this is important to implement the networker interface https://github.com/threefoldtech/zoslight/blob/main/pkg/network_light.go#L34 which is used to generate the stubs https://github.com/threefoldtech/zoslight/blob/ff8a7a63a0c9c717a3e2ceed73112e8fbf99da83/pkg/stubs/network_light_stub.go#L163 this is used by the gateway module
|
please check the comments I clicked approve instead of request changes by mistake |
|
i suggest we close this pr and import the changes from zoslight instead. did other commits there on main |
