Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zos4 enhancement #3806

Open
amiraabouhadid opened this issue Jan 13, 2025 · 1 comment
Open

zos4 enhancement #3806

amiraabouhadid opened this issue Jan 13, 2025 · 1 comment
Assignees
Labels
type_feature New feature or request
Milestone

Comments

@amiraabouhadid
Copy link
Contributor

Which package/s are you suggesting this feature for?

grid_client

Is your feature request related to a problem? Please describe

use enums here

if (features.some(item => item.includes("zmachine-light") || item.includes("network-light"))) {

Describe the solution you'd like

remove strings, use enums instead

@khaledyoussef24
Copy link
Contributor

khaledyoussef24 commented Jan 26, 2025

verified statically and working fine

Image enum was not used but the behavior is fine while testing and already verified on https://github.com//issues/3462 that the zmachine deployments and tests working fine.

but also found this in the k8s script

Image is it possible to deploy a k8s using zos4 node ? while k8s uses wireguard network on the cluster?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type_feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants