Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do complex validations on "deploy" click and show errors per field #161

Open
abom opened this issue Dec 23, 2021 · 1 comment
Open

Do complex validations on "deploy" click and show errors per field #161

abom opened this issue Dec 23, 2021 · 1 comment
Labels
Milestone

Comments

@abom
Copy link

abom commented Dec 23, 2021

Currently, we do instant validations on input change, while this is very cool, it introduces more issues in complex validations like capacity and node check.

We can do instant validation for inputs for simple constraints like required or is number, but for more complex validations like node existence or capacity check, we better to do it on "deploy" click, and just show returned errors nicely per field. This will prevent us from issue like:

  • Keeping up with multiple input changes
  • Doing multiple requests to other services (or implementing a complex login to cancel previous requests like we do here)
  • Duplicate the work of e.g. grid client, which implements more consistent validations with zos itself.

Grid client can return a map with errors for every field, and we can just utilize this and show it in a proper way in the form.

@abom
Copy link
Author

abom commented Dec 30, 2021

Another suggestion is to support standard HTML validations with type property like "email" and "url"...etc

@AhmedHanafy725 AhmedHanafy725 added this to the later milestone Feb 9, 2022
@xmonader xmonader removed this from the milestone Jul 4, 2022
@AhmedHanafy725 AhmedHanafy725 added this to the later milestone Jul 7, 2022
@rkhamis rkhamis transferred this issue from threefoldtecharchive/grid_weblets Apr 19, 2023
@ramezsaeed ramezsaeed added this to the later milestone Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants