Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to retry minting everywhere if no suitable peers found #81

Open
robvanmieghem opened this issue May 13, 2021 · 4 comments
Open

Comments

@robvanmieghem
Copy link
Contributor

robvanmieghem commented May 13, 2021

It is retried in the handler of the deposit anyway on any error

@robvanmieghem robvanmieghem added this to the Later milestone May 13, 2021
@robvanmieghem robvanmieghem changed the title No need to retry minting if no suitable peers found everywhere No need to retry minting everywhere if no suitable peers found May 13, 2021
@DylanVerstraete
Copy link
Contributor

This issue blocks all other operations on the bridge and should be solved asap

@DylanVerstraete DylanVerstraete linked a pull request May 17, 2021 that will close this issue
@robvanmieghem
Copy link
Contributor Author

I don't agree, The thing is the lower level handler should not return an error, just log it. The retry is not done everywhere,I would not have implemented the retry if it was. and if an error occurs, we should not continue.

@DylanVerstraete
Copy link
Contributor

If any error occurs the bridge will just be stuck? I don't think that is a good solution

@robvanmieghem
Copy link
Contributor Author

at least we know the error then, now it is logged and will be rolled out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants