Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFT txn naming convention using Stellar > BSC bridge #149

Open
4 tasks
renauter opened this issue Apr 29, 2022 · 4 comments
Open
4 tasks

TFT txn naming convention using Stellar > BSC bridge #149

renauter opened this issue Apr 29, 2022 · 4 comments

Comments

@renauter
Copy link

renauter commented Apr 29, 2022

While using the Stellar > BSC bridge user get the following transaction information:

bridge_tx_qrcode

Even if there is a warning message user can get confused if he doesn’t scan the QR code to fill the transaction fields and decide to do it manually for some reason (e.g. using Desktop version of TFConnect)
Naming convention is different on TFConnect transaction form and on Bridge transaction information
“Message” field on the TFConnect transaction form corresponds to “Memo” on the Bridge transaction information and the correspondence is not obvious.

Suggestions

Bridge transaction information should follow as much as possible the naming convention on TFConnect transaction form
Also it should be clear that both address and memo are required for the transaction to succeed

  • Change “Destination” text to “ Destination address”
  • Change “Memo” text to “Message / Memo”
  • Reinforce warning message saying that “Message / Memo” field is mandatory
  • Add a “copy to clipboard” option at the end of both mandatory fields (would help to let it even clearer)

source file:
https://github.com/threefoldfoundation/tft/blob/4c9900950723d165f23268dfb421e504979b6c64/bsc/bridges/stellar/frontend/components/Deposit.tsx

@renauter
Copy link
Author

renauter commented May 3, 2022

@sabrinasadik
In order to have a consistent naming convention maybe it would also be a good thing to standardize on the TFConnect app side
On the TFT txn form changing the "Message" field to "Memo" or to "Message / Memo" would avoid some confusion

@sabrinasadik
Copy link

@ken-de-moor pls see request above and create ticket in right repo

@ken-de-moor
Copy link

@sabrinasadik In order to have a consistent naming convention maybe it would also be a good thing to standardize on the TFConnect app side On the TFT txn form changing the "Message" field to "Memo" or to "Message / Memo" would avoid some confusion

I agree, the term used in stellar is Memo, not message, so we will change it on the TF connect side.

@sabrinasadik
Copy link

threefoldtech/threefold_connect_wallet#149

@DylanVerstraete DylanVerstraete removed their assignment Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants