Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: arbitrary base rings for AlgAssAbsOrd #1728

Merged
merged 9 commits into from
Feb 2, 2025
Merged

Conversation

thofma
Copy link
Owner

@thofma thofma commented Jan 30, 2025

No description provided.

@thofma thofma force-pushed the th/byebyefakefmpqmat branch from fd47cc5 to 273bc7d Compare January 30, 2025 20:26
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 69.65889% with 169 lines in your changes missing coverage. Please review.

Project coverage is 76.40%. Comparing base (41aea2f) to head (7d774c7).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/AlgAss/Conversions.jl 39.59% 90 Missing ⚠️
src/AlgAssAbsOrd/Order.jl 75.00% 34 Missing ⚠️
src/AlgAssAbsOrd/Ideal.jl 82.79% 16 Missing ⚠️
src/LinearAlgebra/FakeFmpqMat.jl 58.33% 10 Missing ⚠️
src/NumFieldOrd/NfOrd/Overorders.jl 75.75% 8 Missing ⚠️
src/AlgAssAbsOrd/Elem.jl 87.09% 4 Missing ⚠️
src/AlgAssAbsOrd/Types.jl 90.00% 4 Missing ⚠️
src/AlgAss/Elem.jl 0.00% 1 Missing ⚠️
src/AlgAssAbsOrd/PIP/bley_johnston.jl 75.00% 1 Missing ⚠️
src/AlgAssAbsOrd/PIP/maximal.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1728      +/-   ##
==========================================
- Coverage   76.53%   76.40%   -0.13%     
==========================================
  Files         360      360              
  Lines      113622   113864     +242     
==========================================
+ Hits        86961    86999      +38     
- Misses      26661    26865     +204     
Files with missing lines Coverage Δ
src/AlgAss/AlgGrp.jl 75.08% <100.00%> (-0.05%) ⬇️
src/AlgAss/AlgMat.jl 89.40% <ø> (-0.05%) ⬇️
src/AlgAss/AlgQuat.jl 90.62% <ø> (-0.03%) ⬇️
src/AlgAss/StructureConstantAlgebra.jl 93.60% <100.00%> (-0.02%) ⬇️
src/AlgAssAbsOrd/Conjugacy/Husert.jl 91.30% <100.00%> (ø)
src/AlgAssAbsOrd/ICM.jl 87.69% <100.00%> (ø)
src/AlgAssAbsOrd/LocallyFreeClassGroup.jl 92.47% <100.00%> (ø)
src/AlgAssAbsOrd/PIP/bley_hofmann_johnston.jl 76.74% <100.00%> (+0.20%) ⬆️
src/AlgAssAbsOrd/PIP/unit_group_generators.jl 57.30% <100.00%> (ø)
src/AlgAssAbsOrd/PicardGroup.jl 85.19% <100.00%> (-0.31%) ⬇️
... and 20 more

... and 26 files with indirect coverage changes

@thofma thofma marked this pull request as draft January 31, 2025 07:31
- To generalize some constructions, we need to replace FakeFmpqMat with
  QQMatrix. Since both have different behaviour for `hnf` related
  functions, we first make the names of the methods for FakeFmpqMat
  unique.
@thofma thofma force-pushed the th/byebyefakefmpqmat branch from 273bc7d to 505c640 Compare January 31, 2025 07:31
@thofma thofma changed the title feat: prepare for FakeFmpqMat extinction feat: arbitrary base rings for AlgAssAbsOrd Jan 31, 2025
@thofma thofma force-pushed the th/byebyefakefmpqmat branch from 17c0c99 to 14d38b4 Compare January 31, 2025 15:46
@thofma
Copy link
Owner Author

thofma commented Jan 31, 2025

We can compute trivial examples: Compute a maximal $\mathbf{F}_3[X]$-order in $\mathrm{M}_2(\mathbf{F}_3[X])$ and a maximal $R$-order, where $R$ is the degree localization.

julia> F = GF(3);

julia> K, x = rational_function_field(F, :x);

julia> Fx = K.fraction_field.base_ring; # without words

julia> Finvx = localization(K, degree);

julia> A = matrix_algebra(K, 2);

julia> A.is_simple = 1
1

julia> maximal_order(any_order(A, Fx))
Order of Matrix algebra of dimension 4 over Rational function field over F with basis matrix
[1 0 0 0; 0 1 0 0; 0 0 1 0; 0 0 0 1]

julia> maximal_order(any_order(A, Finvx))
Order of Matrix algebra of dimension 4 over Rational function field over F with basis matrix
[1 0 0 0; 0 1 0 0; 0 0 1 0; 0 0 0 1]

@thofma
Copy link
Owner Author

thofma commented Jan 31, 2025

@fieker this here is to algebras over global fields, what GenOrd is to global fields

@thofma thofma force-pushed the th/byebyefakefmpqmat branch from 4308263 to 7d774c7 Compare February 1, 2025 08:04
@thofma thofma marked this pull request as ready for review February 1, 2025 15:19
@thofma thofma merged commit 429d727 into master Feb 2, 2025
18 checks passed
@thofma thofma deleted the th/byebyefakefmpqmat branch February 2, 2025 09:25
@fieker
Copy link
Collaborator

fieker commented Feb 2, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants