Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink "publish" branch usage #487

Open
jku opened this issue Dec 5, 2024 · 0 comments
Open

Rethink "publish" branch usage #487

jku opened this issue Dec 5, 2024 · 0 comments

Comments

@jku
Copy link
Member

jku commented Dec 5, 2024

Currently push to publish branch happens after online-sign, to mean "this looks ready for the publish-test-prodpublish cycle".

  • this is not 100% accurate since the tests can of course fail: at this point publish branch is a) published to first stage but b) cannot be published to prod as is
  • original reason for "publish" was that it would be easy for the publishing workflow to figure out which commit to publish... but because GitHubs git consistency was not great, we ended up adding a ref argument to the workflow anyway so it's a bit pointless
  • in addition, GitHub settings have recently changed so that you cannot enable Pages for a branch that does not yet exist, making our setup documentation impossible to strictly follow

I think we should bite the bullet and simplify this:

  • online-sign should not push to publish branch
  • publish workflow should just run on main (it gets a ref input anyway)
  • Maybe publish branch still makes sense (to document what has been published) but it's not clear how this relates to e.g. root-signing setup with a staging and production publish....

I'm not sure what the migration looks like for existing installations: I think it's just about switching the Pages branch from publish to main when the actions are upgraded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant