-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Test optional features #33
Comments
hashes/length: #131 |
First, I'm not sure if we need both "xfails" and "optional features". Maybe we can first try to write all tests so "xfails" is enough and it's easy enough to configure even if there are multiple expected failures? Assuming that is the case, a possible solution that would not require changes in the action API or CLI:
|
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Specification has a few optional features. This list is from memory so possibly not complete:
hashes & length in METAFILEs
The single-item dictionary in timestamp and the dictionary in snapshot may or may not contain hashes and/or length. We should check that at least both reasonable options are supported (neither hashes nor length included; and both hashes and length included)
Consistent snapshot
According to spec the "consistent snapshot" feature is SHOULD only. I don't think we're very interested in the "non-consistent" version: I think we should only possibly test it with security in mind -- but have no practical examples at the moment
EDIT: I believe all tests currently implemented require consistent snapshot. I think this is fine, in this aspect we'll be more opinionated than the spec itself: consistent_snapshot really makes much more sense. We should still accept an optional test for non-consistent snapshot... but it's not a priority
The text was updated successfully, but these errors were encountered: