Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review metadata.py #177

Open
jku opened this issue Aug 27, 2024 · 1 comment
Open

review metadata.py #177

jku opened this issue Aug 27, 2024 · 1 comment
Assignees

Comments

@jku
Copy link
Member

jku commented Aug 27, 2024

The code in metadata.py is either never executed (this is 70% of it) or does not affect the test results in any way: I propose we remove the unused code since it gives the impression there is something clever being done but it's mostly not even used.

We can re-add code like this when we have a test that demonstrably needs it.

@jku
Copy link
Member Author

jku commented Aug 29, 2024

I suppose it is possible that some expected client failure actually happens differently without metadata.py (like because the repository fails to process something that it did manage to process with metadata.py)... will need to compare the repository dumps

@AdamKorcz AdamKorcz self-assigned this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants